Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 460146 - Generate Javadoc with Java 8
Summary: Generate Javadoc with Java 8
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.5 M6   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-17 11:39 EST by Markus Keller CLA
Modified: 2015-02-25 02:40 EST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-02-17 11:39:49 EST
(Follow-up to bug 460069 comment 19)
With bug 431236, we started to use the Javadoc tool from Java 8 for org.eclipse.jdt.doc.isv. The other two bundles that generate Javadoc should also use Java 8 now.

One problem with a "mixed" world is that the Javadoc 8 tool creates new anchor references that are incompatible with older generated Javadocs.
An effect of that is that the {@link org.eclipse.core.runtime.Platform#getContentTypeManager() content type manager} in https://help.eclipse.org/luna/topic/org.eclipse.jdt.doc.isv/reference/api/org/eclipse/jdt/core/JavaCore.html#getJavaLikeExtensions-- doesn't work.

Caveat: We also have to add "-Xdoclint:reference" to the other *Options.txt files, see bug 431591.

David, do you plan to update the build to use Java 8 for Mars?

If not, then I'll just copy over the changes that introduced ${eclipse.javadoc} in jdt.doc.isv to the other doc bundles. And I'd remove the obsolete ${javadoc16} variable.
Comment 1 Markus Keller CLA 2015-02-17 11:46:13 EST
Great. Bugzilla doesn't like "--" at the end of a link. Maybe this works? <https://help.eclipse.org/luna/topic/org.eclipse.jdt.doc.isv/reference/api/org/eclipse/jdt/core/JavaCore.html#getJavaLikeExtensions-->
Comment 3 David Williams CLA 2015-02-17 12:45:29 EST
(In reply to Markus Keller from comment #0)

> David, do you plan to update the build to use Java 8 for Mars?

I was not planning on it -- primarily just because I like "staying aware" of what doesn't work, if using "current -1" version of Java and because I assume (possibly incorrectly?) that some users will still be using Java 7 to do their local compiles. 

BUT, at any time you, or other respected member of "releng" :) can request we do change and I would not object. Such as if turns out to be a lot easier or something that'd be fine. Otherwise, I'd fear, "unknown assumptions" will creep into the build, that I'd prefer to have explicit. 

Thanks,
Comment 4 Markus Keller CLA 2015-02-17 13:23:12 EST
I don't know how serious Oracle is with EOLing Java 7, but according to
http://www.oracle.com/technetwork/java/eol-135779.html
there won't be a publicly available version of Java 7 by the time we ship Mars.

It's probably better to turn the switch now rather than in the endgame.
Comment 5 Alexander Kurtakov CLA 2015-02-18 02:35:34 EST
As one of the groups doing their own builds - building Mars with Java 7 is of no interest for us.
Comment 6 Markus Keller CLA 2015-02-19 05:38:59 EST
The Javadoc version used to generate docs should be independent of the Java version that is used to drive the Tycho build.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=4a247c3fe807e267aa7292a35df094e320c47e17

The pde and platform doc bundles now use the same strategy as jdt.doc.isv:
If the ${eclipse.javadoc} property is set, then use that executable.
Otherwise, use ${java.home}/../bin/javadoc[.exe].
Comment 7 Markus Keller CLA 2015-02-23 07:40:45 EST
*Not* verified in 4.5.0.N20150222-2000. Javadocs still generated with 1.7, because the pom.xml didn't forward the eclipse.javadoc variable to the Ant runner.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=52715ee9c3a874a010cbe702e14dca2f88d3b016