Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 459649 - JUnit Plugin-test session fails to shutdown
Summary: JUnit Plugin-test session fails to shutdown
Status: CLOSED WONTFIX
Alias: None
Product: EPP
Classification: Technology
Component: committers-package (show other bugs)
Version: 4.5.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: later   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-11 07:27 EST by Dennis Huebner CLA
Modified: 2021-05-07 12:56 EDT (History)
4 users (show)

See Also:


Attachments
runtime eclipse log (9.85 KB, text/plain)
2015-02-11 07:27 EST, Dennis Huebner CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Huebner CLA 2015-02-11 07:27:56 EST
Created attachment 250714 [details]
runtime eclipse log

Currently I'm testing our xtext examples with Mars M5 DSL Package. I noticed, that if I start a Junit Plugin test session is doesn't shutdown properly, due to an Application error.

How to reproduce:
- Download DSL Mars M5
- Create New -> Example -> Xtext Examples -> Xtext Domain-Model Example
- run org.eclipse.xtext.example.domainmodel.tests project as Junit plugin test
- after tests are passed an error dialog occurs

Log file is attached.

I'm opening this bug against EPP-standard, as I'm not sure which component exactly is causing this problem. Several errors and warnings are logged where different components are involved.
Comment 1 Dennis Huebner CLA 2015-02-13 04:44:52 EST
Connecting to the umbrella bug
Comment 2 Gunnar Wagenknecht CLA 2015-02-16 02:41:34 EST
@Marcel, can you please investigate the Recommenders stack trace? See the attached log.

@Lars, can you have a look at the e4 stack traces? Should there be safeguards or are they a result of another issue?
Comment 3 Marcel Bruch CLA 2015-02-16 03:56:17 EST
(In reply to Gunnar Wagenknecht from comment #2)
> @Marcel, can you please investigate the Recommenders stack trace? See the
> attached log.


The error reporting disables itself in 'normal' test runtimes and additionally can be forced to stay quiet using a system property. Please look at the section 'What build administrators should know (e.g., Maven Tycho)' in [1].

This would prevent the log message to appear.


The log message shown here, AFAICT from my current understanding, is just a WARN message and should not cause an exception nor prevent the IDE from shutting down.

What happened:
The build was executed in a 'real' Eclipse (i.e., the eclipse IDE has the buildId property set). Thus, the error reporter fires up the Configure dialog the first time an error was logged. Due to some build steps, this dialog was closed w/o pressing ok or cancel. After closing the dialog, the error reporter want's to proceed but does recognizes that the dialog was closed 'in an unusual way' - and logs that.


Check the control flow around line 125 [2] to understand what happened.


By analyzing the log, I don't see a reason how the error reporter prevents the IDE from shutting down - but I'll follow Dennis' instructions to reproduce.



[1] https://dev.eclipse.org/recommenders/community/confess/#/guide
[2] https://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/tree/plugins/org.eclipse.recommenders.stacktraces.rcp/src/org/eclipse/recommenders/internal/stacktraces/rcp/LogListener.java#n125
Comment 4 Marcel Bruch CLA 2015-02-16 04:27:45 EST
(In reply to Marcel Bruch from comment #3)
> [...] but I'll follow Dennis' instructions to reproduce.

When disabling the error reporting plugins the test still fails.
I'm confident that we are not causing the error.
Comment 5 Dennis Huebner CLA 2015-02-16 05:20:08 EST
Thanks for explanation Marcel.

In M4 all worked fine. One difference are the two new features from the standard package.

So I suppose it's org.eclipse.oomph.setup.ui.wizards.ConfirmationPage$10.controlResized() or org.eclipse.oomph.setup.ui.SetupUIPlugin$1$1 causing the normal  shutdown failure.

@Eike could you comment on that?
Comment 6 Wayne Beaton CLA 2015-06-02 16:49:06 EDT
(In reply to Dennis Huebner from comment #5)
> Thanks for explanation Marcel.
> 
> In M4 all worked fine. One difference are the two new features from the
> standard package.
> 
> So I suppose it's
> org.eclipse.oomph.setup.ui.wizards.ConfirmationPage$10.controlResized() or
> org.eclipse.oomph.setup.ui.SetupUIPlugin$1$1 causing the normal  shutdown
> failure.
> 
> @Eike could you comment on that?

I believe that this was addressed with Bug 466699.
Comment 7 Eike Stepper CLA 2015-06-03 00:45:16 EDT
M5 is quite long ago. I would first retest that with newer milestones to see if the problem persists.
Comment 8 Eike Stepper CLA 2015-11-17 11:01:57 EST
Dennis, are there any updates here? Have you retested with newer versions of everything? Are you still thinking that this bug is blocking bug 459836?
Comment 9 Dennis Huebner CLA 2015-11-18 06:08:57 EST
(In reply to Eike Stepper from comment #8)
> Dennis, are there any updates here? Have you retested with newer versions of
> everything? Are you still thinking that this bug is blocking bug 459836?

Hi Eike,
I will try to reproduce this one with mars scr1
Comment 10 Dennis Huebner CLA 2015-11-18 08:31:45 EST
Tried with mars sr1 DSL package

"Widget disposed" issue still remain.


Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
2015-11-18 14:28:13.711 java[13511:1130065] *** WARNING: Method userSpaceScaleFactor in class NSWindow is deprecated on 10.7 and later. It should not be used in new applications. Use convertRectToBacking: instead. 
2015-11-18 14:28:13.737 java[13511:1130065] *** WARNING: Method userSpaceScaleFactor in class NSView is deprecated on 10.7 and later. It should not be used in new applications. Use convertRectToBacking: instead. 
!SESSION 2015-11-18 14:28:07.842 -----------------------------------------------
eclipse.buildId=4.5.1.M20150904-0015
java.version=1.8.0_45
java.vendor=Oracle Corporation
BootLoader constants: OS=macosx, ARCH=x86_64, WS=cocoa, NL=de_DE
Framework arguments:  -version 3 -port 65215 -testLoaderClass org.eclipse.jdt.internal.junit4.runner.JUnit4TestLoader -loaderpluginname org.eclipse.jdt.junit4.runtime -testNameFile /var/folders/q2/w6yhy0vs4z9c5wwk8q7pbyxm0000gn/T/testNames93967384228253826.txt -application org.eclipse.pde.junit.runtime.uitestapplication -product org.eclipse.platform.ide -testpluginname org.eclipse.xtext.example.domainmodel.tests
Command-line arguments:  -os macosx -ws cocoa -arch x86_64 -consoleLog -version 3 -port 65215 -testLoaderClass org.eclipse.jdt.internal.junit4.runner.JUnit4TestLoader -loaderpluginname org.eclipse.jdt.junit4.runtime -testNameFile /var/folders/q2/w6yhy0vs4z9c5wwk8q7pbyxm0000gn/T/testNames93967384228253826.txt -application org.eclipse.pde.junit.runtime.uitestapplication -product org.eclipse.platform.ide -data /Users/dhuebner/Downloads/Eclipse 3.app/ws/../junit-workspace -dev file:/Users/dhuebner/Downloads/Eclipse 3.app/ws/.metadata/.plugins/org.eclipse.pde.core/pde-junit/dev.properties -os macosx -ws cocoa -arch x86_64 -consoleLog -testpluginname org.eclipse.xtext.example.domainmodel.tests

!ENTRY org.eclipse.core.net 1 0 2015-11-18 14:28:13.805
!MESSAGE System property http.nonProxyHosts has been set to local|*.local|169.254/16|*.169.254/16 by an external source. This value will be overwritten using the values from the preferences


!ENTRY org.eclipse.oomph.setup.core 2 0 2015-11-18 14:28:46.094
!MESSAGE Widget is disposed
!STACK 0
org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.swt.SWT.error(SWT.java:4491)
	at org.eclipse.swt.SWT.error(SWT.java:4406)
	at org.eclipse.swt.SWT.error(SWT.java:4377)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:799)
	at org.eclipse.swt.widgets.Widget.getDisplay(Widget.java:923)
	at org.eclipse.oomph.ui.UICallback.execInUI(UICallback.java:52)
	at org.eclipse.oomph.setup.impl.SetupTaskImpl.performUI(SetupTaskImpl.java:771)
	at org.eclipse.oomph.setup.impl.PreferenceTaskImpl.perform(PreferenceTaskImpl.java:350)
	at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.doPerformNeededSetupTasks(SetupTaskPerformer.java:2971)
	at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.access$1(SetupTaskPerformer.java:2915)
	at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil$1.run(SetupTaskPerformer.java:4015)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2241)
	at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil.performNeededSetupTasks(SetupTaskPerformer.java:4009)
	at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil.access$0(SetupTaskPerformer.java:4007)
	at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performNeededSetupTasks(SetupTaskPerformer.java:2906)
	at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performTriggeredSetupTasks(SetupTaskPerformer.java:2881)
	at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.perform(SetupTaskPerformer.java:2775)
	at org.eclipse.oomph.setup.ui.wizards.ProgressPage$9.run(ProgressPage.java:550)
	at org.eclipse.oomph.setup.ui.wizards.ProgressPage$11$1.run(ProgressPage.java:635)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

!ENTRY org.eclipse.core.resources 2 10035 2015-11-18 14:28:46.659
!MESSAGE The workspace will exit with unsaved changes in this session.
Comment 11 Gunnar Wagenknecht CLA 2021-05-07 12:56:54 EDT
Closing out old items without activity. If you feel this is still relevant please consider providing a patch and re-open. But I do not plan on working on it.