Community
Participate
Working Groups
One consequence of the fix for bug 457071 is that now there is (once again) some "dirt" left in working tree: This now shows up in "untracked files" from a 'git status' eclipse.platform.releng.tychoeclipsebuilder/rcp.config/rootfiles/ and what is under that (the real dirt) is macosx.cocoa.x86_64/Eclipse.app/Contents/MacOS/eclipse Not sure what the fix is here, unless we figure out how to avoid the "copy up".
Is it a legitimate fix ... or, a partial fix? ... to have a .gitignore entry that say says to ignore rcp.config/rootfiles/? That would at least make it "cleanable" with git clean -Xd
Markus, Tom, ... Do you know enough about "git" and "dirt" to have an opinion about how helpful ".gitignore" would be? I'll "give it a try" as it couldn't hurt, but thought I'd ask. (And, if "is better that nothing" seems the same "trick" could be used in a few other places?).
Yes, .gitignore is exactly meant for such situations. I.e. for files that are generated during a build but should not be committed. .gitignore entries are best created with a tool such as EGit. The pattern format is slightly different from .cvsignore, so you'd have to read http://git-scm.com/docs/gitignore to avoid surprises with manually created patterns. http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=756a0be8559cd9f1d03f1eb352651424aa189676 matches not only /eclipse.platform.releng.tychoeclipsebuilder/rcp.config/rootfiles/* but also /eclipse.platform.releng.tychoeclipsebuilder/rcp.config/source/rootfiles/* => probably not what you meant. EGit's "Team > Ignore" on the folder would generate a .gitignore with contents: /rootfiles/
Thanks for the tip, Markus, on more precession. I checked tonight's nightly, and "git status" did not show it as "dirt", even though it is, still, a form of dirt. Also confirmed that git clean -x -d -f did remove 'rootfiles' directory (as well as /target/ (and others). So, all in all, in the Nightly build, left following modules as showing "modified". modified: eclipse.jdt.core (untracked content) modified: eclipse.jdt.debug (untracked content) modified: eclipse.jdt.ui (untracked content) modified: eclipse.platform.common (untracked content) modified: eclipse.platform.runtime (untracked content) modified: eclipse.platform.ua (untracked content) modified: eclipse.platform.ui (untracked content) modified: rt.equinox.framework (untracked content) I would think the same .gitignore settings could handle a lot of that? Again, if nothing else, making it easier to clean with git clean. Pretty sure 'mvn clean' does not know about "git clean" ... it just cleans what it built?
Counting as "done" (though, someday would like to find a way to get rid of the "partial dirt" ... or, that is, never create it in the first place.
