Community
Participate
Working Groups
With the "clean up" that occurred with bug 457071 I think we can safely remove the "rcp configuration feature" from our main products build or definitions. At least according to my local tests, the build does complete normally, and the "products" look normal, from the spot checking I've done. It will be more complicated to remove from "rcp.id" product (and its SDK) and deserves more thought. One "oddity" is that for the "platform binary repo" we create on our download page, we intentionally include the rcp config feature, and the equinox executables feature. If I had to guess, I'd guess it was so that repo could be used as "a big delta pack". So, will deal with that separately. In addition to simplifying and "cleaning up" the build, I think having the configuration feature there, in addition to what Tycho "configures" on its own, is the cause for bug 432379. But, have not checked that in my local tests builds. Just mentioning here to remember to check once this is in a "nightly".
Oh, and meant to cross reference to bug 401037, which has some of the history, back ground and complications of trying to use "reusable CUs" in a Tycho build.
This is the commit to remove the feature from our 3 main products: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=cbd400adf36fc067d56f2897e04bd37430c88be5 I'll open other bugs on other changes related to to this feature.
From local test builds, all seems well, but did notice that the windows "eclipse.exe" file is not marked as "executable". I think that is normally something done by the "build.properties", in the config feature (or, more exactly, the metadata that the builder creates from the build.properties). But, all the others "eclipse" executables, are indeed "marked" executable on filesystem. My guess is that windows eclipse.exe does not have to be ... but, if it does, we can put that in the product's p2.inf file too. (Besides what I know of Windows, the reason I thin it does not have to be, is that 'rt.exe' of OSGi starter kit is not marked executable, and it does still execute. (We stopped using a "config feature for it, early last release).
as far as I can tell (from nightly) ever thing is "fine" ... better even! (See bug 401037).
