Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 459494 - [console] Scroll-lock is enabled when scrolling a terminated console
Summary: [console] Scroll-lock is enabled when scrolling a terminated console
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Sarika Sinha CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 459517
Blocks:
  Show dependency tree
 
Reported: 2015-02-09 14:06 EST by Eike Stepper CLA
Modified: 2015-04-08 03:58 EDT (History)
1 user (show)

See Also:
daniel_megert: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2015-02-09 14:06:24 EST 
The new auto-scroll-lock should not kick in for consoles of terminated processes.

Steps to reproduce:

1) Launch the following program:

public class ScrollLockTest
{
  public static void main(String[] args)
  {
    for (int i = 0; i < 100; i++)
    {
      System.out.println("I fill the console...");
    }
  }
}

2) When the program has finished scroll the console to the top.

See also: http://bugs.eclipse.org/bugs/show_bug.cgi?id=149393#c49
Comment 1 Sarika Sinha CLA 2015-03-16 05:05:49 EDT 
Working on how to access the state of process from Console plugin.
Comment 2 Dani Megert CLA 2015-04-07 11:39:05 EDT 
A patch was attached to the wrong bug 462950: attachment 252129 [details].
Comment 3 Dani Megert CLA 2015-04-07 11:39:41 EDT 
(In reply to Dani Megert from comment #2)
> A patch was attached to the wrong bug 462950: attachment 252129 [details]
> [diff].

The code is OK and works, but we need to better document
- that this only works for Debug consoles (where the string matches), others 
  might use different descriptions/strings.
- to which string in the other bundle the string must exactly match (provide
  a full path to that property)

You can commit the fix once those additions are made.


The proper fix would introduce a new API that allows to tell the console (page) that one is finished with the console, e.g. detached or terminated. I suggest we open a new bug that covers this improvement, but don't target to any milestone.
Comment 4 Dani Megert CLA 2015-04-08 03:58:00 EDT 
I was thinking about this bug a bit more.

The main issue for Eike was that the next started console is locked because he scrolled up in the terminated console. This no longer happens after fixing bug 459517. Given that the fix here is not complete and introduces a hidden dependency between Console and Debug, we can simply close this bug as WONTFIX.