Community
Participate
Working Groups
Dani noted in https://bugs.eclipse.org/bugs/show_bug.cgi?id=457469#c14 that the navigator tests were failing. We should also activate them for the Gerrit build trigger.
Bug 457868 - [Tests] Activate org.eclipse.ui.tests.navigator tests during Tycho build
New Gerrit change created: https://git.eclipse.org/r/41487
If I run the tests via the Eclipse IDE, they work fine. But if I run them via Tycho they fail. Results : Failed tests: PipelineTest.testNavigatorResourceJava:42 There should be two visible extensions for the pipeline viewer. expected:<2> but was:<1> Tests in error: JstPipelineTest.setUp:42 NullPointer Tests run: 88, Failures: 1, Errors: 1, Skipped: 0 @Mickael, any idea how to solve this?
I don't know in details, but typical reasons for failure with Tycho when it's working for IDE are: * test sorting: IDE and Tycho may not run tests in the same order. The solution to overcome this issue is to have TestSuites to orchestrate tests instead of relying on runner conventions. * Missing "behavioural" dependency: test bundle actually needs another bundle to be present in order to have tests succeeding. The depenency has to be added to the tycho-surefire-plugin configuration, or to the MANIFEST.MF (more portable but more intrusive)
(In reply to Mickael Istria from comment #4) > * test sorting: IDE and Tycho may not run tests in the same order. The > solution to overcome this issue is to have TestSuites to orchestrate tests > instead of relying on runner conventions. AFAICS we are using TestSuites, see https://git.eclipse.org/r/#/c/41487 > * Missing "behavioural" dependency: test bundle actually needs another > bundle to be present in order to have tests succeeding. The depenency has to > be added to the tycho-surefire-plugin configuration, or to the MANIFEST.MF > (more portable but more intrusive) Is there a way to find out if that is the case?
(In reply to Lars Vogel from comment #5) > (In reply to Mickael Istria from comment #4) > > * Missing "behavioural" dependency: test bundle actually needs another > > bundle to be present in order to have tests succeeding. The depenency has to > > be added to the tycho-surefire-plugin configuration, or to the MANIFEST.MF > > (more portable but more intrusive) > > Is there a way to find out if that is the case? I don't know a systematic way to do this. When this happen, it's generally necessary to audit the code and bundle behaviour and find out hints of what could be missing. And the reasons I gave were the 2 more frequent in other bundles that I worked on to support tycho-surefire-plugin, but there are many more possible causes.
In that case, it appears the test uses an extension that is provided by JDT UI. I will submit a patch that fixes it, but that implies that there is a cyclic dependency between platform-ui and JDT-ui because of this test requirement.
Suggested change: https://git.eclipse.org/r/#/c/41549/
New Gerrit change created: https://git.eclipse.org/r/41909
Gerrit change https://git.eclipse.org/r/41549 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e3ac8e052f3e09d75166cbb26530cf3b8243c3f6
Mickael with your change in http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e3ac8e052f3e09d75166cbb26530cf3b8243c3f6 the tests run locally fine for me but they still fail on the server. Do you know how to fix this? https://git.eclipse.org/r/41487 contains the auto activation of the tests during the Gerrit build trigger.
New Gerrit change created: https://git.eclipse.org/r/47376
Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.
Mickael, IIRC you fixed that recently. Please reopen if that is wrong
