Comment 1 Lars Vogel 2015-01-19 13:05:19 EST

Update to Java 6: https://git.eclipse.org/r/#/c/39884/

Comment 2 Lars Vogel 2015-01-19 13:07:02 EST

Missing annotations: https://git.eclipse.org/r/39886

Comment 3 Lars Vogel 2015-01-20 04:45:21 EST

Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=bd8df253be954033c122d7e043e998a4a1880ff5 and https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0b4c932db7b17b1a4484aa12e3ad9e0658af91c6

Comment 4 Andrey Loskutov 2015-01-21 02:53:59 EST

https://git.eclipse.org/r/#/c/39996/ still fails because it uses StringBuilder:

See https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4203/consoleText:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.22.0:compile (default-compile) on project org.eclipse.ui.tests.navigator: Compilation failure: Compilation failure:
[ERROR] /jobs/genie.eclipse.platform/eclipse.platform.ui-Gerrit/workspace/tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/ResourceTransferTest.java:[65]
[ERROR] StringBuilder sb = new StringBuilder();
[ERROR] ^^^^^^^^^^^^^
[ERROR] StringBuilder cannot be resolved to a type
[ERROR] /jobs/genie.eclipse.platform/eclipse.platform.ui-Gerrit/workspace/tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/ResourceTransferTest.java:[65]
[ERROR] StringBuilder sb = new StringBuilder();
[ERROR] ^^^^^^^^^^^^^
[ERROR] StringBuilder cannot be resolved to a type
[ERROR] 2 problems (2 errors)

Comment 5 Andrey Loskutov 2015-01-21 02:56:02 EST

Ignore my last comment, the change https://git.eclipse.org/r/#/c/39996/ was not rebased to yesterday's head.

Comment 6 Lars Vogel 2015-01-21 03:36:35 EST

(In reply to Andrey Loskutov from comment #5)
> Ignore my last comment, the change https://git.eclipse.org/r/#/c/39996/ was
> not rebased to yesterday's head.

;-)

Comment 7 Lars Vogel 2015-01-26 19:15:30 EST

Verified in Git

Comment 8 Dani Megert 2015-02-11 04:09:52 EST

(In reply to Lars Vogel from comment #7)
> Verified in Git

Lars and Thibault, how about running the suite before committing? ;-)

This change results in a test failure on all platforms, see e.g.
http://download.eclipse.org/eclipse/downloads/drops4/N20150210-2000/testresults/html/org.eclipse.ui.tests.navigator_win32.win32.x86_7.0.html


The reason is that you added tests that were commented out:

		//addTest(new TestSuite(DnDTest.class));
		// Does not pass on all platforms see bug 264449
		//addTest(new TestSuite(PerformanceTest.class));

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c71908b06f1936ed6f70c66174c5cc502c2067cf

Comment 9 Lars Vogel 2015-02-11 04:41:32 EST

(In reply to Dani Megert from comment #8)
> (In reply to Lars Vogel from comment #7)
> > Verified in Git
> 
> Lars and Thibault, how about running the suite before committing? ;-)

Of course I ran the tests but it is hard to find Windows platform specific issues by running the tests on Linux. ;-)

Thanks for the fix Dani.

Comment 10 Dani Megert 2015-02-11 04:51:58 EST

(In reply to Dani Megert from comment #8)

Sorry, this comment should have gone into bug 457870.

Comment 11 Dani Megert 2015-02-11 04:53:41 EST

(In reply to Lars Vogel from comment #9)
> (In reply to Dani Megert from comment #8)
> > (In reply to Lars Vogel from comment #7)
> > > Verified in Git
> > 
> > Lars and Thibault, how about running the suite before committing? ;-)
> 
> Of course I ran the tests but it is hard to find Windows platform specific
> issues by running the tests on Linux. ;-)

Well, well, the suite also fails on Linux (and DNFs on Mac OS X):
http://download.eclipse.org/eclipse/downloads/drops4/N20150210-2000/testresults/html/org.eclipse.ui.tests.navigator_linux.gtk.x86_64_8.0.html