456556 – [GTK3] no branch tree in git history view

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 456556 - [GTK3] no branch tree in git history view

Summary: [GTK3] no branch tree in git history view

Status:	CLOSED DUPLICATE of bug 435773

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.5
Hardware:	All Linux

Importance:	P3 major (vote)
Target Milestone:	---
Assignee:	Platform-SWT-Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-01-02 18:40 EST by Andrey Loskutov
Modified:	2015-01-03 07:49 EST (History)
CC List:	1 user (show)

See Also:

Attachments
no branch tree with GTK3 (237.26 KB, image/png) 2015-01-02 18:40 EST, Andrey Loskutov	no flags	Details
nice branch tree with GTK2 (245.41 KB, image/png) 2015-01-02 18:40 EST, Andrey Loskutov	no flags	Details
gtk3 history text rendering broken (216.50 KB, image/png) 2015-01-03 03:49 EST, Andrey Loskutov	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrey Loskutov

2015-01-02 18:40:16 EST

Created attachment 249687 [details]
no branch tree with GTK3

Build id: I20141210-2000 (Eclipse 4.5 M4).
Using latest egit 3.6.1 nightly build (but I think this is unrelated to the egit version).
Ubuntu 14.10, KDE, Clearlooks-Phenix theme (same results with oxygen-gtk).

Open history view on any git project containing multiple branches. There is no graphical branch info shown in the "message" column. Neither branch/head/tag labels nor the "tree" connection lines are drawn.

Start now same Eclipse/workspace but using GTK2 (export SWT_GTK3=0 env. var.).
Everything is just fine, one can see the expected data.

Please compare attached pictures.

Comment 1 Andrey Loskutov

2015-01-02 18:40:43 EST

Created attachment 249688 [details]
nice branch tree with GTK2

Comment 2 Andrey Loskutov

2015-01-03 03:23:07 EST

Interesting enough, the "simple" projects have that history, but egit/jgit doesn't. So it seems that some "advanced" SWT paint operations cause SWT renderer to break at some time without any error.

Related code:
egit/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/SWTPlotRenderer.java
egit/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java

Right now I have no clue why GTK3 shouldn't work but GTK2 is OK.

Comment 3 Andrey Loskutov

2015-01-03 03:49:14 EST

Created attachment 249690 [details]
gtk3 history text rendering broken

(In reply to Andrey Loskutov from comment #2)
> Right now I have no clue why GTK3 shouldn't work but GTK2 is OK.

At least I've got an idea: as soon as the table area has a scrollbar the painting is broken! 

Thus the small example projects with three commits are "OK", and any history of particular file with less then 5 commits is "OK".

"OK" with GTK3 means: the history graph is shown but the table text painting is broken so that one can't read any text, see attached picture.

Comment 4 Andrey Loskutov

2015-01-03 07:49:16 EST


*** This bug has been marked as a duplicate of bug 435773 ***