Comment 1 Konstantin Komissarchik 2014-12-17 13:41:37 EST

Thanks for offering to try your hand contributing to Sapphire. General contributor information can be found at the following page.

http://www.eclipse.org/sapphire/developers/

For this enhancement, you will need to modify MasterDetailsEditorPage class. The content outline is rendered in the createContentOutline() method. In response to a double-click event, you will want to grab MasterDetailsContentNodePart object that was the target of the event and call the setExpanded(boolean) method.

Once you've implemented the changes, please export the patch and attach it to this bug.

Comment 2 Dmitry K 2014-12-18 10:15:35 EST

Created attachment 249530 [details]
Proposed patch

Comment 3 Konstantin Komissarchik 2014-12-18 14:57:06 EST

Looks good. A few items:

1. The listener should check if the selection is exactly one. I don't think we want it firing if there are multiple nodes selected.

2. Please add yourself to @author tag and up at the header.

3. Lastly, before I can accept your patch, you need to accept Eclipse Contributor License Agreement.

http://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Eclipse_Foundation_Contributor_License_Agreement

Comment 4 Dmitry K 2014-12-19 09:55:05 EST

Created attachment 249552 [details]
Proposed patch #2

Corrected patch & added it again

Comment 5 Konstantin Komissarchik 2014-12-19 13:12:03 EST

Almost there...

You've signed CLA with your gmail account, but you've used your onpositive account in the contribution. This is causing the gatekeeper to reject the commit. Two options:

1. Change your bugzilla account to use your onpositive e-mail address and possibly resign the CLA. Alternatively, you can create another account with your onpositive e-mail address, if you want to keep the two separate.

2. Tell me that you want to use your gmail account for the contribution and I will make the requisite adjustments. The downside of this approach is that your contribution will not be attributed to onpositive in the project's dashboard.

Comment 6 Dmitry K 2014-12-22 06:48:33 EST

I've tried to change my acoount's email, but getting msg "The following error(s) have occurred: - Unable to change your email address" without any details while trying from both Firefox & Chrome. Is there a way to overwork this error or maybe administrator could change my e-mail?

Best Regards, Dmitry.

Comment 7 Dmitry K 2014-12-23 06:52:33 EST

Konstantin, I've recovered an account registered with my onpositive mail, & I would sign CLA (and re-add my patch if needed) as soon as CLA signing system would be avail (unfortunately it ssems to be down now). Sorry for delay.

Comment 8 Dmitry Karpenko 2014-12-24 11:32:09 EST

Created attachment 249619 [details]
Proposed patch

Comment 9 Konstantin Komissarchik 2014-12-26 17:13:57 EST

9 : http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=8d8b14ea3009912259773a4aae9e4d9d3527c24d

8.2 : http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?h=8.2.x&id=48e4584a5f1fdc5e45aa617e6038abf68347f190

Thanks for your contribution! Please verify in the build using either 8.2 or 9 stream.

https://hudson.eclipse.org/sapphire/

Comment 10 Dmitry K 2014-12-29 07:01:42 EST

Verified using Catalog sample & jars from 9.0.x » #95, works OK for me

Comment 11 Dmitry Karpenko 2014-12-29 07:03:15 EST

> Verified using Catalog sample & jars from 9.0.x » #95, works OK for me
Sorry, posted this from a wrong account

Comment 12 Konstantin Komissarchik 2014-12-30 13:42:54 EST

Thanks for the verification. Closing.