Comment 1 Dani Megert 2014-12-11 04:35:36 EST

Created attachment 249333 [details]
Fix

Comment 2 Thomas Watson 2014-12-11 08:46:23 EST

What is the need to export org.eclipse.equinox.internal.p2.ui.misc?  Is something actually needing that package?  If so where is the bug that is requesting for new API?

I know there is a policy to export all packages by the eclipse project, but I think that is a pretty bad practice myself.

Comment 3 Dani Megert 2014-12-11 09:26:10 EST

(In reply to Thomas Watson from comment #2)
> What is the need to export org.eclipse.equinox.internal.p2.ui.misc?  Is
> something actually needing that package?  If so where is the bug that is
> requesting for new API?
> 
> I know there is a policy to export all packages by the eclipse project, but
> I think that is a pretty bad practice myself.

Yes, this is based on the Eclipse policy and the fact that I get an error saying that not all packages are exported (since the project does not ignore explicitly in its project settings), it takes my workspace settings, which are set according to the official Eclipse rules.

Comment 4 Pascal Rapicault 2014-12-16 17:20:43 EST

Fix pushed to master

Comment 5 Dani Megert 2014-12-17 05:33:22 EST

This fix causes an API Tools error due to API Tools bug 454143. Also, the bundle version should not be changed since it was already increased to 2.4.0 during Mars.

Comment 6 Dani Megert 2014-12-17 05:34:44 EST

Created attachment 249493 [details]
Fix for API Tools and bundle version

Comment 7 Markus Keller 2014-12-17 08:33:08 EST

Comment on attachment 249493 [details]
Fix for API Tools and bundle version

(In reply to Dani Megert from comment #5)
> This fix causes an API Tools error due to API Tools bug 454143.
I guess you meant bug 455324?

However, that's not the problem that causes the API Tools error in StringMatcher.

The problem is that Pascal didn't release Dani's patch but wrongly added org.eclipse.equinox.internal.p2.ui.misc as an API package.

Fix is to revert http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=84d25da9d031f5cec643f4b75b024ec37257208f and following commits and release the provided patch.

Comment 8 Dani Megert 2014-12-17 09:13:48 EST

(In reply to Markus Keller from comment #7)
> Comment on attachment 249493 [details] [diff]
> Fix for API Tools and bundle version
> 
> (In reply to Dani Megert from comment #5)
> > This fix causes an API Tools error due to API Tools bug 454143.
> I guess you meant bug 455324?

No, I meant bug 454845, but that's obsolete now.


> 
> However, that's not the problem that causes the API Tools error in
> StringMatcher.
> 
> The problem is that Pascal didn't release Dani's patch but wrongly added
> org.eclipse.equinox.internal.p2.ui.misc as an API package.

Oh, good catch! I blindly assumed my patch was committed and didn't verify.

Comment 9 Pascal Rapicault 2014-12-17 09:14:56 EST

Sorry about this I did not notice the patch...
I added the x-internal.

Comment 10 Markus Keller 2014-12-17 09:55:17 EST

(In reply to Dani Megert from comment #5)
> Also, the
> bundle version should not be changed since it was already increased to 2.4.0
> during Mars.

Pascal, please revert that change before it ends up in an I-build.


(In reply to Dani Megert from comment #8)
> No, I meant bug 454845, but that's obsolete now.
Or rather bug 307750...

Comment 11 Dani Megert 2014-12-17 10:00:14 EST

(In reply to Markus Keller from comment #10)
> (In reply to Dani Megert from comment #8)
> > No, I meant bug 454845, but that's obsolete now.
> Or rather bug 307750...

Indeed!

Comment 12 Pascal Rapicault 2014-12-17 10:03:08 EST

Done.