Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 453160 - much "invalid html" in specific download pages
Summary: much "invalid html" in specific download pages
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M4   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 451808
  Show dependency tree
 
Reported: 2014-11-25 04:17 EST by David Williams CLA
Modified: 2014-12-09 11:25 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-11-25 04:17:06 EST
Bug 421390 covers the main download page, for the Eclipse project, namely, 
http://download.eclipse.org/eclipse/downloads/
which is now pretty clean. 

But, specific pages are still pretty "messy". 

That's using w3c validator, at 
http://validator.w3.org/

For example, 
http://download.eclipse.org/eclipse/downloads/drops4/N20141120-0700/
reports 357 errors. 

As I see it, it's required to "clean up" these pages, before we can use the Eclipse Foundation's "solstice" theme.
Comment 1 David Williams CLA 2014-11-25 04:39:35 EST
I've actually been working on this off and on for past week or so, so now 
http://download.eclipse.org/eclipse/downloads/drops4/N20141124-2000/
has only 28 errors, and I think I've just fixed those, so will re-check for I-build on Tuesday. 

With two caveats.
 
1). I didn't do the greatest job in tracking the changes in Git. They are all marked, but not with bug number. I used an annotation of 

[releng] misc formatting, and fixing "style" errors

(This was primarily because I thought I was just going to fix a few, here and there, at first). 

And it involves two repositories: 
eclipse.platform.releng.buildtools, and
eclipse.platform.releng.aggregator

2) Part of my "approach" to fixing the errors, was to "take stuff out". There were (and still are some) less than ideal HTML written or generated. 

The implication being that some fixes are still needed, just to get the page to display better then it currently is. (for example, some elements need centering, some padding, etc.). And, for much of that, I want to use CSS, instead of the current approach of repeating the same HTML over and over again, with is brittle and error prone.

And in some cases, these improvements may "interact" with moving the page to the solstice theme.

I'll cover those improvements in this bug, as well.
Comment 2 David Williams CLA 2014-11-25 19:26:46 EST
Unfortunately, a previous "fix" was missed (or, had a typo?) so that a space was missing: 

td><img src = "repo.gif"alt="JDT Repo" /> JDT Runtime Repo </td>

And this is in the 'testManifest.xml' file. 


http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=048d531f4f779a1f373ff2ea0c1e52bd002db445
Comment 3 David Williams CLA 2014-12-09 11:25:23 EST
Should be fixed in Mars M4. For example, 
http://download.eclipse.org/eclipse/downloads/drops4/I20141208-2000/
validates as HTML5 with a minor warning. 

Will need to "keep an eye" on it, since future changes will take place, and have not found an easy way to validate, such as in a "unit test". (If you know of one, let me know). 

But, the basics are done. 

I hope "HTML5" suffices ... and you don't need "XHTML Strict" (which .. would be better ... but ... the "Solstice theme" is HTML 5 so that's what we have for now). 

And ... many other pages to clean up!