Community
Participate
Working Groups
While working on bug 429739 I noticed that although a number of call sites were using the convenience nsEmbedString class, there were some omissions, and there was also no equivalent class for XULRunner's 8-bit strings which meant that all the relevant code was duplicated for each use.
Similar refactoring effort was started sometime back in below Gerrit, but not yet completed: "Deduplicate nsEmbed(C)String toString": https://git.eclipse.org/r/#/c/23605/ See if this can be taken forward.. currently it has few open comments to be resolved.Thanks!
(In reply to Niraj Modi from comment #1) > Similar refactoring effort was started sometime back in below Gerrit, but > not yet completed: > "Deduplicate nsEmbed(C)String toString": https://git.eclipse.org/r/#/c/23605/ > > See if this can be taken forward.. currently it has few open comments to be > resolved.Thanks! I notice that the patch you linked to doesn't wrap the calls to nsEmbedString_new so it's not as convenient as my approach. Although I mentioned it in the original description, I was planning on creating an nsEmbedCString class separately, but I can address that here too if you prefer. I have already made the appropriate changes locally so I can comment on how they relate to your existing comments. Comment on Mozilla.java: I don't append the HTML bytes to the stream in pages. As far as I can tell, the stream does not have a memory limit and can accept the entire byte array at once. The loop is therefore unnecessary. Comments on nsEmbed(C)String.java: I don't change any stringification code, so I don't think there is anything to be done there.
Moving to M7.
One gerrit change https://git.eclipse.org/r/#/c/36154/ for the refactoring is already merged to master. The second refactoring change request https://git.eclipse.org/r/#/c/39792/ needs to be reviewed and tested. Will do this post 4.5.
No more development work is planned for XULRunner support. I think it's better to not touch the code now as it would require more testing on different versions & platforms.
XULRunner has been deprecated and removed from the source tree, see https://groups.google.com/d/msg/mozilla.dev.platform/_rFMunG2Bgw/C-4PcHj9IgAJ Closing this request since makes little sense to invest in a dead technology.
