Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 449022 - The getRealm() method of the SWTObservables class should be moved to a different class
Summary: The getRealm() method of the SWTObservables class should be moved to a differ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M4   Edit
Assignee: Simon Scholz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 449462
  Show dependency tree
 
Reported: 2014-10-27 19:06 EDT by Simon Scholz CLA
Modified: 2014-11-04 05:48 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Scholz CLA 2014-10-27 19:06:52 EDT 
Since all methods of the SWTObservables class, except of the getRealm() method, are deprecated, this method should be moved to the Realm class itself.

After moving this method the whole SWTObservables class should be deprecated.
Comment 1 Simon Scholz CLA 2014-10-27 19:31:39 EDT 
As the Realm class has no access to the org.eclipse.swt.widgets.Display class, I decided to make a top level class out of the DisplayRealm class, which is currently an inner class of the SWT Observables.
Comment 2 Simon Scholz CLA 2014-10-27 19:43:46 EDT 
Please see: https://git.eclipse.org/r/#/c/35565/
Comment 3 Lars Vogel CLA 2014-10-28 02:51:09 EDT 
Would code which uses the old getRealm() and new code work together?
Comment 4 Lars Vogel CLA 2014-11-03 14:46:26 EST 
Thanks Simon, with the delegation to the new class in SWTObservables everything looks good to me. Merged with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=36859dd1c67e720f61fd0565dac632e3b27623e8
Comment 7 Dani Megert CLA 2014-11-04 05:48:26 EST 
(In reply to Lars Vogel from comment #6)
> Also updated the pom.xml with
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=d9f8b1ec7eaf2bec4f16ac1670bc11f7f9f62e6f

The Releng Plug-in's POM Version Tool is your friend ;-).