Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 447191 - [EditorMgmt] EditorPart#isSaveOnCloseNeeded() not honoured when closing dirty Editor Part that is split
Summary: [EditorMgmt] EditorPart#isSaveOnCloseNeeded() not honoured when closing dirty...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.12   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.14 M1   Edit
Assignee: Kalyan Prasad Tatavarthi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-14 15:49 EDT by Phil Beauvoir CLA
Modified: 2019-10-01 04:36 EDT (History)
3 users (show)

See Also:

Attachments
Test RCP Project (7.73 KB, application/octet-stream)
2019-08-27 13:50 EDT, Phil Beauvoir CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Beauvoir CLA 2014-10-14 15:49:56 EDT 
This is in our RCP Application, Archi - http://www.archimatetool.com

If I have an Editor Part open that is dirty, then split the Editor via Ctrl+_ or Ctrl+{, and then close the Editor Part I see a dialog window, "Save Parts" inviting me to save the Editor Part. As I return false on EditorPart#isSaveOnCloseNeeded() this should not happen.

This behaviour is only happening when the Editor is split.

Related perhaps to Bug #428664.
Comment 1 Phil Beauvoir CLA 2019-08-27 08:58:48 EDT 
This is still happening in 4.12. 

I wonder if it is related to issues such as Bug #543442 and Bug #550419
Comment 2 Phil Beauvoir CLA 2019-08-27 13:50:46 EDT 
Created attachment 279693 [details]
Test RCP Project

Test RCP Project that demonstrates the problem.

Run this from Eclipe 4.12 or 4.13.

When you run it there will be one EditorPart open that is marked "dirty" (it's a Browser component in the EditorPart)

From the app's "File" menu select "Split" to split the EditorPart.

You will be prompted to save the resource even though the Editor Part returns false for EditorPart#isSaveOnCloseNeeded()
Comment 3 Eclipse Genie CLA 2019-09-24 06:02:35 EDT 
New Gerrit change created: https://git.eclipse.org/r/150047
Comment 5 Phil Beauvoir CLA 2019-09-27 03:46:52 EDT 
Thanks! Will test soon.
Comment 6 Phil Beauvoir CLA 2019-09-28 11:52:38 EDT 
Tested with the commit from Gerrit on Windows 10 and I can confirm the fix works.

Thanks!
Comment 7 Alexander Kurtakov CLA 2019-10-01 01:27:10 EDT 
This caused javadoc failure to build. https://download.eclipse.org/eclipse/downloads/drops4/I20190930-1800/compilelogs/platform.doc.isv.javadoc.txt
Comment 8 Eclipse Genie CLA 2019-10-01 01:43:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/150410
Comment 10 Alexander Kurtakov CLA 2019-10-01 01:55:39 EDT 
Should be fixed now.
Comment 11 Dani Megert CLA 2019-10-01 04:36:29 EDT 
(In reply to Alexander Kurtakov from comment #10)
> Should be fixed now.
Thanks.