Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 446707 - if link is created during "install", it should be removed in "uninstall"
Summary: if link is created during "install", it should be removed in "uninstall"
Status: CLOSED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 4.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 407775
Blocks: 442729
  Show dependency tree
 
Reported: 2014-10-10 17:06 EDT by David Williams CLA
Modified: 2019-11-04 20:32 EST (History)
5 users (show)

See Also:


Attachments
patch to remove "link" before "cleanup", during uninstall (2.31 KB, patch)
2014-10-10 17:44 EDT, David Williams CLA
no flags Details | Diff
patch as above, but 'force:true" added for creation (2.58 KB, patch)
2014-10-10 17:57 EDT, David Williams CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-10-10 17:06:58 EDT
+++ This bug was initially created as a clone of Bug #407775 +++

While we do some of this "manually", at the moment, I just happened across the code in p2 where this could be better fixed. (I was thinking I'd have to open a bug in Tycho, but in another context, they say they "delegate to p2" for publishing products ... ) 

Anyway, just by chance, looking for things related to eclipse.ini, I happened across

EquinoxExecutableAction::computeInstallActions

That is at least one place where 

install and uninstall data is put in the touch point. 

There it's clear that the "ln" (for MacOS) is put in the "install" but the link is not removed in the uninstall data.
Comment 1 David Williams CLA 2014-10-10 17:44:58 EDT
Created attachment 247808 [details]
patch to remove "link" before "cleanup", during uninstall
Comment 2 David Williams CLA 2014-10-10 17:57:56 EDT
Created attachment 247809 [details]
patch as above, but 'force:true" added for creation

If it were up to me, I'd also add "force" to the link creation. This is in part because the problem was originally reported by an adopter, with an "installer" that "builds on" p2, and -- in some way that I do not understand -- a "left over" link was interfering with their installer completing normally. 

And, in part, because link-copy behavior on the Mac, differs on than on Linux, and I wonder if that's related to "the real" problem. (On linux, cp -r <directory> will copy the symbolic link. On the mac, the "link" gets turned into a "file" (from the little I have tested/looked at it). 

And, in part, because -- after all -- the link is pretty important. The chances of their being a "real" file or link there that does something different than we intend is just about 0, and ... if the link we intend is not created, then "eclipse won't work" and would likely be perceived as "our" fault.
Comment 3 Eclipse Genie CLA 2019-11-04 20:32:08 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.