Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 442528 - We should not have empty performance targets
Summary: We should not have empty performance targets
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.3.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M2   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 442455
  Show dependency tree
 
Reported: 2014-08-25 15:49 EDT by David Williams CLA
Modified: 2014-09-17 06:08 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-08-25 15:49:34 EDT 
See bug 442455 for more detail, but it is confusing (at best) for us to some tests marked as having performance tests, when they really don't. 

From what I could see, the following have an empty performance target: 

eclipse.jdt.core/org.eclipse.jdt.apt.pluggable.tests/test.xml
eclipse.jdt.core/org.eclipse.jdt.compiler.apt.tests/test.xml
eclipse.jdt.core/org.eclipse.jdt.compiler.tool.tests/test.xml
eclipse.jdt.core/org.eclipse.jdt.core.tests.builder/test.xml
eclipse.jdt.core/org.eclipse.jdt.core.tests.compiler/test.xml
eclipse.jdt.core/org.eclipse.jdt.core.tests.model/test.xml

eclipse.jdt.ui/org.eclipse.ltk.core.refactoring.tests
eclipse.jdt.ui/org.eclipse.ltk.ui.refactoring.tests


Hope you don't find me combining "core" with "ui". 

Would appreciate either removing empty targets, or "comment them out" so they are not detected by the CBI-tool (and test framework) that mark them as "performance tests).
Comment 1 David Williams CLA 2014-08-25 16:13:49 EDT 
Did I forget to include

org.eclipse.jdt.apt.tests ?

It's still coming back as "no results". 

I might have gotten confused, since my lists were all from "visual inspection" of 41 test.xml files .... might have copy/pasted one or two wrong?
Comment 2 Jay Arthanareeswaran CLA 2014-08-26 02:16:22 EDT 
The Core part is here:

http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=ca5419c1e7501f8671202d3f26a44fb9de145612

I don't have commit rights for UI. Markus will take care of this.
Comment 4 Sasikanth Bharadwaj CLA 2014-09-17 04:25:34 EDT 
Verified for 4.5 M2 using I20140916-2000 build