Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 442456 - Should not have empty performance targets
Summary: Should not have empty performance targets
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M2   Edit
Assignee: Sarika Sinha CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 442455
  Show dependency tree
 
Reported: 2014-08-25 02:02 EDT by David Williams CLA
Modified: 2015-03-17 02:55 EDT (History)
3 users (show)

See Also:
Michael_Rennie: review+

Attachments
Patch to remove the empty performance targets (309 bytes, patch)
2014-08-25 04:51 EDT, Sarika Sinha CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-08-25 02:02:49 EDT 
As I point out in bug 442455, org.eclipse.ant.tests.core' bundle, has an empty performance target. 

This causes a lot of confusion (well, for me) when I see it has a performance target (they are computed during the build, and listed in 'test.properties') but then I see "nothing happen" during the performance test, so assume something is broken.  I suggest it either be removed, or if you really want to keep something there for documentation, comment out the actual target, similar to: 

  <!-- This target runs the performance test suites. 
  <target name="performance">
  </target>
  -->

And having it commented out assumes that the "CBI task" that creates test.properties actually does a true "XML parsing" and is not just greping for certain strings.
Comment 1 Sarika Sinha CLA 2014-08-25 04:35:50 EDT 
I think we can remove the empty performance target.

10 years before this was added in ant.tests.core and ant.tests.ui

Performance target was added with details in ant.tests.ui but nothing was added to ant.tests.core

It can be added later if we intend to add some performance tests.
Comment 2 Sarika Sinha CLA 2014-08-25 04:51:45 EDT 
Created attachment 246302 [details]
Patch to remove the empty performance targets

Patch removes the empty performance targets from ant.tests.core plugin
Comment 4 Dani Megert CLA 2014-09-01 08:13:39 EDT 
I've replaced the fix with the pattern used elsewhere:

  <!-- This target runs the performance test suites.
  Disabled for bug 442455: We should not have empty performance targets
  <target name="performance">
  </target>
  -->
Comment 5 Sarika Sinha CLA 2015-03-17 02:55:12 EDT 
Verified by code inspection using
Eclipse SDK

Version: Mars (4.5)
Build id: I20150316-2000