Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 437069 - make runtests.sh (and other files) identical in 'production' as in test package
Summary: make runtests.sh (and other files) identical in 'production' as in test package
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 441889 461678
Blocks: 430938
  Show dependency tree
 
Reported: 2014-06-10 12:54 EDT by David Williams CLA
Modified: 2020-06-03 15:09 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-06-10 12:54:49 EDT
When working on bug 436197 noticed a number of differences between the version in "production" directory, vs. the one packaged with unit tests. 

This bug will be used to both track making sure they are "the same" ... and cleaned up. 

By "cleaned up" I notice they  both set 'vmcmd' .... but I believe that's set in other places too? So should probably be set in just one place. (just as a potential example).
Comment 1 David Williams CLA 2014-06-10 13:08:25 EDT
I should also note, it would be nice not to have two versions of this file, (or the other "run tests" files ... but, not positive, yet, that's (easily) possible.
Comment 2 David Williams CLA 2014-07-29 03:12:39 EDT
Recently, while getting "releng.tests" incorporated back into the build (or, the production tests runs, to be exact), these two sets of "doing tests" diverged even more ... partially out of expedient ways to get the tests to run on my local build machine ... using my local test builds, etc. ... so there is a lot of "consolidation" to do now. In this bug, I'll try and track the main things.
Comment 3 David Williams CLA 2014-08-15 14:58:13 EDT
There is nothing to see yet, but added a "refactoring" bug 441889 as a blocker of this one, since once the "production scripts" are refactored and working well, some of the changes could "move down" to the "packaged" version of eclipse-Automated-Tests-*. 

So, committers and community, eventually I would like your feedback. While I think all the changes will be "nothing but goodness" and long term make things easier, if anyone is currently using our eclipse-Automated-Tests-*. 
 package to run some tests, they will likely have to make some changes to their scripts or procedures. I think.
Comment 4 David Williams CLA 2015-01-14 01:28:59 EST
This should not be a priority until performance tests are "completely done" ... so will try for Mars.
Comment 5 David Williams CLA 2015-03-16 18:25:19 EDT
Which changes needed for "Mac App", I'd say this is now a bug, not an enhancement.
Comment 6 David Williams CLA 2015-08-13 18:30:00 EDT
See bug 474822 comment 9 for a very large commit which "blindly" synchronized the "duplicate" files. 

Since the two sets had grown so far apart, the strategy will be to take all the changes, and then if the "standalone" version does not work, to fix the few things that are broken, or contradict documentation. In the event that proves too difficult, that commit in bug 474822 comment 9 should be reverted.
Comment 7 David Williams CLA 2015-08-16 17:43:59 EDT
Status: 

I was able to get the tests to run, on Linux, but had to make a number of local changes to define variables that were otherwise undefined. 

So, I think the strategy of comment 6 is still best, BUT, is will take many iterations before "all fixed", especially for all platforms, and, especially to update the documentation at 

https://wiki.eclipse.org/Platform-releng/Automated_Testing

That documentation is very out of date (even if the "merge" of comment 6 was not done). 

Would also be a good time, since knee deep in it, anyway, is to investigate bug 430938 again, and either fix or remove that "feature" from test.xml. As things currently are, I doubt that some of the tests said to "run on Java 5, or Java 6" are true, any longer. This also is another way the documentation at 
https://wiki.eclipse.org/Platform-releng/Automated_Testing
is out of date. As one step in fixing 430938 I should just define runtimes for all the EE levels (5 though 8) and see what breaks.
Comment 8 David Williams CLA 2015-10-21 10:50:09 EDT
Untargeting for specific milestone, since not sure which milestone I'll finish this in.
Comment 9 David Williams CLA 2016-08-11 15:24:22 EDT
Doing a mass "reset to default assignee" of 52 bugs to help make clear it will (very likely) not be me working on things I had previously planned to work on. I hope this will help prevent the bugs from "getting lost" in other people's queries. Feel free to "take" a bug if appropriate.
Comment 10 Eclipse Genie CLA 2020-06-03 15:09:17 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.