Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 436001 - [TERMINALS] The default encoding must be UTF-8 on Windows, and should be remembered per connection if changed
Summary: [TERMINALS] The default encoding must be UTF-8 on Windows, and should be reme...
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Target (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.3   Edit
Assignee: Project Inbox CLA
QA Contact: Uwe Stieber CLA
URL:
Whiteboard:
Keywords:
: 435139 (view as bug list)
Depends on: 443046
Blocks:
  Show dependency tree
 
Reported: 2014-05-27 23:41 EDT by Martin Oberhuber CLA
Modified: 2015-02-20 23:46 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2014-05-27 23:41:32 EDT
As per my comment here:

   https://bugs.eclipse.org/bugs/show_bug.cgi?id=420474#c9

the winpty code requires UTF-8 encoding, so the handling of default encoding must be changed:

1. UTF-8 must be the default on Windows Local Terminals and Mac local terminals.
   1a) On Linux Local, the default local host encoding should be used as default
   1b) On Telnet, SSH and Serial, either ISO-8859-1 or UTF-8 is reasonable
   --> If UTF-8 is used as default on ALL connections it is a workable solution.

2. IDEEncoding.getResourceEncoding() should be used again to populate the 
   encoding selection combo, such that a custom encoding which a user has
   entered for his workspace is available in the selection combo.

3. When entering an invalid encoding, there should be an error message and not
   direct fallback to iso-8859-1. Test case: enter "cp437" as encoding, this
   is unsupported in Java7 (at least on my host) - would like to see an error.

4. Encoding should be remembered per host / connection. Today it seems shared
   across all terminal connectors. But it is very likely that I need UTF-8
   on my Windows Local terminal, ISO-8859-1 on my remote SSH session, and 
   US-ASCII on my Serial line. Different SSH hosts may use different encodings,
   and user's selection should be remembered.
Comment 1 Martin Oberhuber CLA 2014-05-27 23:41:57 EDT
*** Bug 435139 has been marked as a duplicate of this bug. ***
Comment 3 Martin Oberhuber CLA 2015-02-20 23:39:53 EST
Remembering the encoding per connection was fixed for 1.3 20150220:
See bug 443046