Description Maxime Porhel 2014-05-27 12:05:51 EDT

+++ This bug was initially created as a clone of Bug #435808 +++ discovered during Sirius 1.0.0 RC2 homologation on Eclipse Luna SDK RC2

See Bug 435808 for more details.

The popupAny contributions (locationUri popup:org.eclipse.ui.popup.anybefore=additions for example) are added twice in
org.eclipse.e4.ui.internal.workbench.ContributionsAnalyzer.XXXgatherMenuContributions(MMenu, List<MMenuContribution>, String, ArrayList<MMenuContribution>, ExpressionContext, boolean) :

   if (!filtered && menuContribution.isToBeRendered() && popupAny) {
      // process POPUP_ANY first
      toContribute.add(menuContribution);
   } else if (filtered || (!popupTarget && !parentID.equals(id))
					|| !menuContribution.isToBeRendered()) {
     continue;
   }
   includedPopups.add(menuContribution);
 }
 toContribute.addAll(includedPopups);


The if/else if block should be improved to avoid duplicated entries or a LinkedHAshSet should be used.