Comment 1 Richard Burcher 2014-05-27 11:38:06 EDT

Hi Folks,

Couple of quick items for the Luna release:

- * Submit your IP Logs ASAP.

- Could you please add some additional information to the release review
documentation in the description section. Namely, what does the release
implement or fix; what would users find interesting about the release.

- Please seek PMC approval for the review materials.


Cheers,

Richard

Comment 2 Richard Burcher 2014-05-27 12:46:34 EDT

IP Log submitted.

Comment 3 Yves YANG 2014-05-27 18:35:59 EDT

Thanks Richard, 

I thought I did last week. 

>- * Submit your IP Logs ASAP.

Done,

>- Could you please add some additional information to the release review
documentation in the description section. Namely, what does the release
implement or fix; what would users find interesting about the release.

Done,

>- Please seek PMC approval for the review materials.

Done,

Best regards

Comment 4 Richard Burcher 2014-05-28 11:57:03 EDT

(In reply to Yves YANG from comment #3)
> Thanks Richard, 
> 
> I thought I did last week. 
> 
> >- * Submit your IP Logs ASAP.
> 
> Done,
> 
> >- Could you please add some additional information to the release review
> documentation in the description section. Namely, what does the release
> implement or fix; what would users find interesting about the release.
> 
> Done,
> 
> >- Please seek PMC approval for the review materials.
> 
> Done,
> 
> Best regards

Thanks Yves:)

Comment 5 Richard Burcher 2014-05-30 15:26:50 EDT

Created attachment 243727 [details]
Approved IP Log

Comment 6 Richard Burcher 2014-06-02 15:32:06 EDT

Comment on attachment 243727 [details]
Approved IP Log

Incorrectly saved attachment. Email headers included.

Comment 7 Richard Burcher 2014-06-02 15:32:20 EDT

Created attachment 243856 [details]
Approved IP Log

Comment 8 Richard Burcher 2014-06-02 15:32:50 EDT

Hi Folks,

Could you please:

- Seek PMC approval for the release review materials.


- Please attach PMC approval discussion email url.


Cheers,

Richard

Comment 9 Yves YANG 2014-06-02 16:51:23 EDT

Thanks for the reminder. I just resend an email to technology-pmc.

Comment 10 Richard Burcher 2014-06-04 08:54:20 EDT

PMC +1 from Chris Aniszczyk.


Please attach PMC approval discussion email url.

Comment 11 Yves YANG 2014-06-04 10:24:16 EDT

Here is:

http://dev.eclipse.org/mhonarc/lists/technology-pmc/msg05782.html

Comment 12 Wayne Beaton 2014-06-04 11:07:06 EDT

Yves, it looks like there are some legal files missing from the project's downloads:

Missing (edl-v10.html|epl-v10.html) in file: org.eclipse.xwt.feature_1.0.0.RC1-20140523-2153.jar
Missing (edl-v10.html|epl-v10.html) in file: org.eclipse.xwt.source.feature_1.0.0.RC1-20140523-2153.jar
Missing (edl-v10.html|epl-v10.html) in file: org.eclipse.xwt.workbench.feature_1.0.0.RC1-20140523-2153.jar
Missing (edl-v10.html|epl-v10.html) in file: org.eclipse.xwt.workbench.source.feature_1.0.0.RC1-20140523-2153.jar
Missing license.html in file: org.eclipse.xwt.feature_1.0.0.RC1-20140523-2153.jar
Missing license.html in file: org.eclipse.xwt.source.feature_1.0.0.RC1-20140523-2153.jar
Missing license.html in file: org.eclipse.xwt.workbench.feature_1.0.0.RC1-20140523-2153.jar
Missing license.html in file: org.eclipse.xwt.workbench.source.feature_1.0.0.RC1-20140523-2153.jar

Missing about.html in file: org.eclipse.xwt.css.source_1.0.0.RC1-20140523-2153.jar
Missing about.html in file: org.eclipse.xwt.emf.source_1.0.0.RC1-20140523-2153.jar
Missing about.html in file: org.eclipse.xwt.forms.source_1.0.0.RC1-20140523-2153.jar
Missing about.html in file: org.eclipse.xwt.pde.source_1.0.0.RC1-20140523-2153.jar
Missing about.html in file: org.eclipse.xwt.source_1.0.0.RC1-20140523-2153.jar
Missing about.html in file: org.eclipse.xwt.ui.workbench.source_1.0.0.RC1-20140523-2153.jar
Missing about.html in file: org.eclipse.xwt.xml.source_1.0.0.RC1-20140523-2153.jar

The full report (which is generated when we build the simultaneous release repository) is here:

http://build.eclipse.org/simrel/luna/reporeports/reports/layoutCheck.txt

This needs to be addressed before we can declare the review successful.

Comment 13 Richard Burcher 2014-06-04 13:23:23 EDT

Release review made public.

Comment 14 Yves YANG 2014-06-04 16:06:32 EDT

Erdal, can you fix the problem of files missing ?

Comment 15 Erdal Karaca 2014-06-04 18:23:23 EDT

Done - the build.properties' source setting has been missing in the plugins/features.

Comment 16 Yves YANG 2014-06-04 20:19:13 EDT

Thanks Erdal!

The build 1.0.0.RC2 is available here:
   http://download.eclipse.org/xwt/updates/

Comment 17 Sharon Corbett 2014-06-05 14:21:20 EDT

Hi Erdal;

The About.html files included actually appear to be Notice.html files.  You'll want to rename those.

The About.html files need to follow one of these templates [1]/

[1] https://www.eclipse.org/legal/epl/about.php

Thanks,
Sharon

Comment 18 Erdal Karaca 2014-06-05 14:49:12 EDT

Thanks for catching this, Sharon!
I have triggered a new build.
The update site is the same as in comment #16.

(In reply to Sharon Corbett from comment #17)
> Hi Erdal;
> 
> The About.html files included actually appear to be Notice.html files. 
> You'll want to rename those.
> 
> The About.html files need to follow one of these templates [1]/
> 
> [1] https://www.eclipse.org/legal/epl/about.php
> 
> Thanks,
> Sharon

Comment 19 Yves YANG 2014-06-06 08:31:26 EDT

Thanks Erdal,

Please let us know what we need to do further!

Comment 20 Yves YANG 2014-06-09 20:46:22 EDT

This is a kind remainder. Please let us know what we need to do to complete this reveiw. 

Thanks !
Yves

Comment 21 Wayne Beaton 2014-06-09 23:22:30 EDT

I believe that we have everything that we need for XWT. We're on track for a successful release review conclusion on Wednesday, June 11.

Comment 22 Yves YANG 2014-06-10 17:43:34 EDT

(In reply to Wayne Beaton from comment #21)
> I believe that we have everything that we need for XWT. We're on track for a
> successful release review conclusion on Wednesday, June 11.

Thanks!

Comment 23 Richard Burcher 2014-06-11 13:25:47 EDT

We declare this release review successful.

Please continue with your release.

Comment 24 Erdal Karaca 2014-06-11 16:11:48 EDT

Thanks!

(In reply to Richard Burcher from comment #23)
> We declare this release review successful.
> 
> Please continue with your release.

Comment 25 Yves YANG 2014-06-11 17:11:44 EDT

Thanks!

Erdal, please remove all tag (Incubation) and release the final 1.0.0.

Comment 26 Yves YANG 2014-06-11 17:55:50 EDT

I have removed all "Incubation". Please check it and go ahead to make the release.