Community
Participate
Working Groups
bug to track release review for inclusion with Luna release.
IP Log received.
Hi Folks, Couple of quick items for the Luna release: - Please submit review materials. Please provide a Description section that describes what the release implements or fixes; what would users find interesting about the release. - Please seek PMC approval for the review materials. Cheers, Richard
I've forwarded the IP Log to the IP Team for their review.
Hi Folks, Couple of items for the project: - Please submit review materials. Please provide a Description section that describes what the release implements or fixes; what would users find interesting about the release. - Please seek PMC approval for the review materials. - Please attach PMC vote email url. Cheers, Richard
(In reply to comment #3) > I've forwarded the IP Log to the IP Team for their review. It turns out that I was confused. I'm waiting for a response from the project to a question regarding the IP Log.
Sorry, I don't quite understand the question about IP logs. I can't find mentioned org.apache.xerces anywhere inside the gmf tooling git repository. I am actually not 100% sure that GMF-Tooling does not use it at all because I am with the project for only 4 years and there may be something tricky in the past before me. But I am 100% sure that nothing with regards to org.apache.xerces has changed since the 3.1 Kepler release where apparently there were no such questions. It is difficult for me to imagine what may be the changes during this period which would require the addition of such dependency. Can I ask what is the process of the verification, can I locally reproduce your steps and find org.apache.xerces_2.9.0.*.jar you can't map? Is my understanding correct that right now it would be simpler to just go forward with piggyback CQ for that without exact understanding of how and why it may be used?
(In reply to Michael Golubev from comment #6) > I can't find mentioned org.apache.xerces anywhere inside the gmf tooling git > repository. But it is in the downloads. > I am actually not 100% sure that GMF-Tooling does not use it at all because > I am with the project for only 4 years and there may be something tricky in > the past before me. > > But I am 100% sure that nothing with regards to org.apache.xerces has > changed since the 3.1 Kepler release where apparently there were no such > questions. That I didn't notice it before is not relevant. Current builds are producing update sites that include this JAR. > It is difficult for me to imagine what may be the changes during this period > which would require the addition of such dependency. > > Can I ask what is the process of the verification, can I locally reproduce > your steps and find org.apache.xerces_2.9.0.*.jar you can't map? wbeaton@build:/home/data/httpd/download.eclipse.org/modeling/gmp/gmf-tooling> find . -name org.apache.xerces_2.9.0.* > Is my understanding correct that right now it would be simpler to just go > forward with piggyback CQ for that without exact understanding of how and > why it may be used? That would be simpler, yes. But shouldn't you know why that file is being included by your build?
Thanks for quick reply. I can confirm that the this jar is included into the downloads for a couple of years now. I am not brave enough to play with the build procedure at RC3+3 day, and I am definitely not going to remove this jar from all the downloads from the past. So I have just created https://dev.eclipse.org/ipzilla/show_bug.cgi?id=8338. Sorry for delays with this
(In reply to Richard Burcher from comment #2) > - Please submit review materials. Please provide a Description section that > describes what the release implements or fixes; what would users find > interesting about the release. > > - Please seek PMC approval for the review materials. Done: https://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg03189.html
Michael, it looks like there are some legal files missing from the project's downloads: Missing about.html in file: org.eclipse.gmf.runtime.lite.svg.source_1.0.0.201405070759.jar Anthony identified the bundle as being a product of GMF Tooling (see bug 435845 comment 8). The full report (which is generated when we build the simultaneous release repository) is here: http://build.eclipse.org/simrel/luna/reporeports/reports/layoutCheck.txt This needs to be addressed before we can declare the review successful.
Should be fixed with https://git.eclipse.org/c/gmf-tooling/org.eclipse.gmf-tooling.git/commit/?id=f24803f1ab72bf8fca74e3afffa3409086212358
(In reply to comment #11) > Should be fixed with > https://git.eclipse.org/c/gmf-tooling/org.eclipse.gmf-tooling.git/commit/?id=f24803f1ab72bf8fca74e3afffa3409086212358 It doesn't appear in the June 6 Luna repository, but I do see it in ~/downloads/modeling/gmp/gmf-tooling/updates/milestones-3.2.RC4 I believe that it's safe to assume that this will end up in the final release bits.
Created attachment 244163 [details] Approved IP Log
Release review scheduled for June 18.
(In reply to Wayne Beaton from comment #12) > It doesn't appear in the June 6 Luna repository, but I do see it in > > ~/downloads/modeling/gmp/gmf-tooling/updates/milestones-3.2.RC4 > > I believe that it's safe to assume that this will end up in the final > release bits. I have just rechecked that after luna aggregation build #597 gmf-tooling had been fixed and removed from both ../layoutCheck.txt and ..//licenseConsistency.html reports.
Release review was successful. Please continue on with your release.
Successful review.
