Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 435502 - [Usability] The New Child/Diagram context menu subitems waste screen space
Summary: [Usability] The New Child/Diagram context menu subitems waste screen space
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Others (show other bugs)
Version: 1.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: M6   Edit
Assignee: Shuai Li CLA
QA Contact: Remi Schnekenburger CLA
URL:
Whiteboard: dx usability
Keywords:
: 463611 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-05-22 07:05 EDT by Ronan Bar CLA
Modified: 2015-04-03 11:45 EDT (History)
6 users (show)

See Also:


Attachments
Menu Screenshot (9.87 KB, image/png)
2015-03-31 09:19 EDT, Camille Letavernier CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ronan Bar CLA 2014-05-22 07:05:42 EDT
Can we drop the "Create a new" text from all sub menus. It is a waste of space and actually makes finding what you want harder as you tend to look at the first few letters of a sentence to find what your looking for.
Comment 1 Remi Schnekenburger CLA 2014-05-22 07:39:41 EDT
You are right, I did not want to change the existing behavior, but this would spare space and add visibility. I will update it
Comment 2 Remi Schnekenburger CLA 2014-06-04 06:21:17 EDT
UML and SysML menus have been updated with new labels. Closing bug
Comment 3 Ronan Bar CLA 2014-06-09 07:34:31 EDT
The New Diagram menu has the same issue.
Comment 4 Eclipse Genie CLA 2015-02-05 11:49:43 EST
Gerrit change submitted: https://git.eclipse.org/r/41190
Comment 6 Remi Schnekenburger CLA 2015-02-06 03:38:14 EST
Closing bug.
Comment 7 Ronan Bar CLA 2015-02-12 05:56:53 EST
Not fixed for New Diagram/New Table context menus. In fact the New Diagram menu shouldn't even menion UML e.g. "Create a new UML Class Diagram" should be "Class Diagram"
Comment 8 Eclipse Genie CLA 2015-02-12 08:26:04 EST
New Gerrit change created: https://git.eclipse.org/r/41714

WARNING: this patchset contains 8326 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 9 Shuai Li CLA 2015-02-12 08:28:51 EST
(In reply to Ronan B from comment #7)
> Not fixed for New Diagram/New Table context menus. In fact the New Diagram
> menu shouldn't even menion UML e.g. "Create a new UML Class Diagram" should
> be "Class Diagram"

Can you please provide a screenshot of your context menu? I don't have "Create a new" in the model explorer context menu.

The "UML" text, in front of diagram names, is dropped in Gerrit change 41714.
Comment 10 Eclipse Genie CLA 2015-02-13 09:43:36 EST
Gerrit change https://git.eclipse.org/r/41714 was merged to [master].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=3b35c9c087bec38eff487cc4088ed3403cedd7d7

WARNING: this patchset contains 8326 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 11 Remi Schnekenburger CLA 2015-02-13 09:46:29 EST
Shuai, could you do the cherry pick from master to luna?

Thanks
Comment 12 Remi Schnekenburger CLA 2015-02-13 09:46:57 EST
(In reply to Remi Schnekenburger from comment #11)
> Shuai, could you do the cherry pick from master to luna?
> 
> Thanks

And could you also modify the new child for SysML diagrams?
Comment 13 Camille Letavernier CLA 2015-03-31 09:19:33 EDT
Created attachment 252038 [details]
Menu Screenshot

Current "new diagram" menu with some UML and SysML diagrams
Comment 14 Camille Letavernier CLA 2015-03-31 09:19:41 EDT
Class, Package and Inner Class diagrams have the "UML" prefix, whereas other diagrams don't have it. I think the UML prefix should be removed everywhere (Or added everywhere, if we want to avoid SysML diagrams to be located between 2 different UML Diagrams - or other languages)
Comment 15 Shuai Li CLA 2015-03-31 10:37:38 EDT
I think we want to drop "UML" and "SysML" everywhere, unless inapplicable (e.g. "SysML Requirements Table" is still relevant and should remain as is).

There also needs to be another kind of sorter for the viewer, rather than alphabetical.
Comment 16 Camille Letavernier CLA 2015-03-31 10:41:55 EDT
> I think we want to drop "UML" and "SysML" everywhere, unless inapplicable (e.g. "SysML Requirements Table" is still relevant and should remain as is).

We can't anticipate conflicts for all languages, and we can't assume that the icon will be sufficient to distinguish languages either (not in all cases at least). So it seems a little bit risky to remove all prefixes

> There also needs to be another kind of sorter for the viewer, rather than alphabetical.

Agreed: they should be separated by language when applicable. Unfortunately, I don't think there is a strong notion of Language in Papyrus (The notion exists for the Wizards, but I don't think it has been generalized to ensure that all Editors must have a Language)
Comment 17 Eclipse Genie CLA 2015-03-31 12:11:38 EDT
New Gerrit change created: https://git.eclipse.org/r/44930

WARNING: this patchset contains 2622 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 18 Shuai Li CLA 2015-04-01 03:28:31 EDT
The above change is for the issue mentioned in this bug. I opened another bug for the discussion on modeling language association with menus and views.

Notice that currently SysML and UML diagrams are mixed in the "New Diagram" menu. We can separate them (within the same menu) but one may also want them to be mixed and sorted alphabetically. The choice to separate them may not be obvious.
Comment 19 Shuai Li CLA 2015-04-01 03:28:57 EDT
(In reply to Shuai Li from comment #18)
> The above change is for the issue mentioned in this bug. I opened another
> bug for the discussion on modeling language association with menus and views.
> 
> Notice that currently SysML and UML diagrams are mixed in the "New Diagram"
> menu. We can separate them (within the same menu) but one may also want them
> to be mixed and sorted alphabetically. The choice to separate them may not
> be obvious.

Forgot to reference Bug 463642
Comment 20 Camille Letavernier CLA 2015-04-01 04:30:42 EDT
*** Bug 463611 has been marked as a duplicate of this bug. ***
Comment 22 Camille Letavernier CLA 2015-04-01 04:43:32 EDT
> Gerrit change https://git.eclipse.org/r/44930 was merged to [master].

I close this task. Additional discussion about whether creation menus should be prefixed with the language should happen in Bug 463642
Comment 23 Shuai Li CLA 2015-04-03 11:45:51 EDT
(In reply to Remi Schnekenburger from comment #11)
> Shuai, could you do the cherry pick from master to luna?
> 
> Thanks

Bug 463891 is for Luna. Gerrit change for that bug is: https://git.eclipse.org/r/45230