Comment 1 Richard Burcher 2014-05-23 09:40:22 EDT

Created attachment 243448 [details]
Approved IP Log

Comment 2 Richard Burcher 2014-05-23 13:49:44 EDT

Please seek PMC approval.

Comment 3 Stephan Eberle 2014-05-23 14:17:31 EDT

(In reply to Richard Burcher from comment #2)
> Please seek PMC approval.

Already done: http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg03129.html

Comment 4 Stephan Eberle 2014-05-26 06:59:18 EDT

(In reply to Stephan Eberle from comment #3)
> (In reply to Richard Burcher from comment #2)
> > Please seek PMC approval.
> 
> Already done: http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg03129.html

... and got a positive response: http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg03130.html

Comment 5 Richard Burcher 2014-06-04 13:21:09 EDT

Release review made public.

Comment 6 Wayne Beaton 2014-06-11 12:15:27 EDT

Not sure how this crept in at this late date, but it looks like Sphinx may be missing some about.html files:

Missing about.html in file: org.eclipse.sphinx.emf.metamodelgen.source_0.8.0.201406040902.jar
Missing about.html in file: org.eclipse.sphinx.emf.metamodelgen_0.8.0.201406040902.jar

http://build.eclipse.org/simrel/luna/reporeports/reports/layoutCheck.txt

Stephan, please investigate. These files need to be included in the release bits.

Comment 7 Stephan Eberle 2014-06-11 12:19:46 EDT

(In reply to Wayne Beaton from comment #6)
> Not sure how this crept in at this late date, but it looks like Sphinx may
> be missing some about.html files:
> 
> Missing about.html in file:
> org.eclipse.sphinx.emf.metamodelgen.source_0.8.0.201406040902.jar
> Missing about.html in file:
> org.eclipse.sphinx.emf.metamodelgen_0.8.0.201406040902.jar
> 
> http://build.eclipse.org/simrel/luna/reporeports/reports/layoutCheck.txt
> 
> Stephan, please investigate. These files need to be included in the release
> bits.

I've fixed this today morning. The issue should be come as soon as we'll unleash our RC4 build to the Sphinx update site and simrel repo later today.

Comment 8 Richard Burcher 2014-06-11 13:02:15 EDT

We declare this release review successful; after comment 6 is resolved.

Please continue with your release.

Comment 9 Wayne Beaton 2014-06-11 16:26:51 EDT

(In reply to Stephan Eberle from comment #7)
> I've fixed this today morning. The issue should be come as soon as we'll
> unleash our RC4 build to the Sphinx update site and simrel repo later today.

Works for me.

(In reply to Richard Burcher from comment #8)
> We declare this release review successful; after comment 6 is resolved.

Richard, consider this my +1 to carry forward with the declaration of success.

Comment 10 Stephan Eberle 2014-06-12 04:13:13 EDT

As you can see in the latest simrel build report for the copyrights (http://build.eclipse.org/simrel/luna/reporeports/reports/copyrights.html), the required legal files are no longer missing in org.eclipse.sphinx.emf.metamodelgen.feature.group (very much like in all other Sphinx bundles).

Comment 11 Richard Burcher 2014-06-23 10:03:23 EDT

Successful review.