Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 435052 - SWT: Scout model value not updated after click on ToolButton
Summary: SWT: Scout model value not updated after click on ToolButton
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Scout (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-16 08:17 EDT by Jeremie Bresson CLA
Modified: 2021-08-19 11:10 EDT (History)
1 user (show)

See Also:


Attachments
Example form to test the bug. (4.67 KB, application/octet-stream)
2014-05-16 08:17 EDT, Jeremie Bresson CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremie Bresson CLA 2014-05-16 08:17:06 EDT
Created attachment 243175 [details]
Example form to test the bug.

The use case described in Bug 422646#c2 [1] is not working.

* SWT UI.
* Implementation from ToolButtons (Bug 422646)

--------------------

To reproduce it:
* Requirement: A form with a StringField and a ToolButton (see example Form attached).
* Enter something ("Hello" for example), let the cursor in the StringField.
* Click on the ToolButton

== Current result ==
getValue() on the StringField returns null

== Expected result ==
getValue() on the StringField returns "Hello"

--------------------

Tested by Matthias Nick: develop 16.05.2014
Tested by me: Luna-M6

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=372610#c2
Comment 1 Jeremie Bresson CLA 2014-05-16 08:26:46 EDT
> (In reply to Jeremie Bresson from comment #0)

The use case is decribed in Bug 372610.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=372610#c2

Bug 422646 is about adding ToolButtons to the scout framework (SWT UI).


Sorry for the confusion.
Comment 2 Matthias Nick CLA 2014-05-20 05:14:00 EDT
Pushed first change to gerrit: https://git.eclipse.org/r/#/c/26892/
Comment 3 Jeremie Bresson CLA 2014-05-20 06:01:54 EDT
I just discussed with Matthias Nick our use case and the regression.

You can take the Luna-M5 EPP (in order to get a Scout 3.10 where our use case is working). I assume it is still working on 3.10-latest.

Download the sample project in this thread:
http://www.eclipse.org/forums/index.php/mv/msg/631535/1234551/#msg_1234551

Import it in your workspace:
Import > existing projects into workspace > from archive > {path to the zip file}.

Start the application.

The Button xxx.client.ui.forms.DesktopForm.RefreshButton prints the content of the StringFields (Scout Model layer) in the console (Sysout).

You see that if you type something in the StringField and hit the button, the value is updated in the Scout-model even if the focus is still in the field.

It is working on 3.10, but we need exactly this use-case with Scout 4.0.
Comment 4 Matthias Nick CLA 2014-05-20 08:38:03 EDT
Change was pushed to gerrit: https://git.eclipse.org/r/#/c/26892/
Comment 5 Matthias Nick CLA 2014-05-20 08:38:27 EDT
Change was merged with commit: 960b70f7b6c790ac43a0884e7258d5dab49384f9

@Jérémie, can you please verify?
Comment 6 Jeremie Bresson CLA 2014-05-21 05:23:15 EDT
I tested it with the continous build version in a test project. 

We will verify this bug if the use case is working in our real application after RC1 is out.
Comment 7 Jeremie Bresson CLA 2014-06-03 09:30:46 EDT
Tested with org.eclipse.scout.rt.ui.swt 4.0.0.20140521-1250

OK for our project.
Comment 8 Matthias Zimmermann CLA 2014-07-01 03:16:40 EDT
Shipped with Eclipse Luna Release