This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 434991 - [QuickAccess] Ctrl+3 quick access popup, while search field is hidden, does not use the correct scope
Summary: [QuickAccess] Ctrl+3 quick access popup, while search field is hidden, does n...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.4 RC3   Edit
Assignee: Paul Webster CLA
QA Contact: Daniel Rolka CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-15 12:34 EDT by Noopur Gupta CLA
Modified: 2018-06-08 08:15 EDT (History)
5 users (show)

See Also:
bsd: review+
daniel.rolka: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2014-05-15 12:34:49 EDT 
Luna 4.4 M7 I20140501-0200.

- Hide quick access search field or hide the toolbar.
- Press Ctrl+3. The quick access popup will appear.
- Type something, say "tool". Some entries will be shown, with the message "Press Ctrl+3 to show all matches" at the bottom.
- Press Ctrl+3 => Nothing happens.
- Try the same in quick access search field after restoring it and it works there.

Also, in the popup, "Previous Choices" are not shown in the result most of the times. It shows up after typing most of the characters required for the search.
Comment 1 Dani Megert CLA 2014-05-19 05:43:18 EDT 
This is a regression compared to 4.3.x.
Comment 2 Dani Megert CLA 2014-05-19 05:50:32 EDT 
Looks like the scope is not correctly set: if I invoke the popup while in the editor, none of the editor commands are shown.
Comment 3 Paul Webster CLA 2014-05-28 11:30:45 EDT 
Fix available with https://git.eclipse.org/r/27471

PW
Comment 4 Lars Vogel CLA 2014-05-28 14:06:58 EDT 
(In reply to Paul Webster from comment #3)
> Fix available with https://git.eclipse.org/r/27471
> 
> PW

Thanks Paul for the fix. I can confirm that the fix solves comment 2. The "press Ctrl+3 again" issue from comment 1 is not solved AFAICS. Hard to tell if the fix targets both issues or only the one from Dani.
Comment 5 Paul Webster CLA 2014-05-28 14:13:49 EDT 
(In reply to Lars Vogel from comment #4)
> Thanks Paul for the fix. I can confirm that the fix solves comment 2. The
> "press Ctrl+3 again" issue from comment 1 is not solved AFAICS. Hard to tell
> if the fix targets both issues or only the one from Dani.

This fix targets that you can't use editor commands in the popup when in an editor (the scope problem).  I feel that's the more serious problem.

I didn't look into hitting CTRL+3 twice.

PW
Comment 6 Paul Webster CLA 2014-05-28 15:00:00 EDT 
Turns out the CTRL+3 fix was trivial, so I added it.

Lars, Brian, could you please review?

PW
Comment 8 Dani Megert CLA 2014-05-29 05:30:27 EDT 
Verified in I20140528-2000.