Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 434619 - Switching to GTK+ 2/3 should be easier for products
Summary: Switching to GTK+ 2/3 should be easier for products
Status: VERIFIED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Launcher (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: Luna RC2   Edit
Assignee: Arun Thondapu CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 436485
  Show dependency tree
 
Reported: 2014-05-12 04:22 EDT by Dani Megert CLA
Modified: 2014-09-30 03:02 EDT (History)
4 users (show)

See Also:
arunkumar.thondapu: review+
tjwatson: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2014-05-12 04:22:13 EDT
Currently one has to set an environment variable to switch/use to another GTK+ version. This is no ideal for products.

We should add an option, so that it can be easily set via launcher, e.g. in the eclipse.ini:

--launcher.GTK_version
3
Comment 1 Alexander Kurtakov CLA 2014-05-12 06:24:45 EDT
Changing it to equinox.launcher component as this is beyond swt (which needs to know which gtk version to load prior to start). 
The --launcher.GTK_version (or similar) must be handled in equinox launcher to set the env variable for swt and as it has full control over the env the following variants can be handled:
* no parameter - let swt pick it's default
* env variable set (no launcher parameter) - load the gtk version requested by the env variable (if available)
* launcher parameter - even if env variable set ignore it and load the gtk version as requested by launcher parameter (if available)
Comment 2 Dani Megert CLA 2014-05-12 07:18:27 EDT
Arun, please take care of this.
Comment 3 Sravan Kumar Lakkimsetti CLA 2014-05-13 03:04:19 EDT
A new patch is uploaded to gerrit at
https://git.eclipse.org/r/#/c/26419/
Comment 4 Thomas Watson CLA 2014-05-14 11:13:13 EDT
Moving to RC2.  Arun would you be able to get the launcher rebuilt for this one (assuming the review for https://git.eclipse.org/r/#/c/26419/ is done).
Comment 5 Arun Thondapu CLA 2014-05-21 14:20:30 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #3)
> A new patch is uploaded to gerrit at
> https://git.eclipse.org/r/#/c/26419/

Thanks Sravan! Patch pushed to master - https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=06e3fb2d6c734a0570c1af2694b69ebe27fa2a0f

(In reply to Thomas Watson from comment #4)
> Moving to RC2.  Arun would you be able to get the launcher rebuilt for this
> one (assuming the review for https://git.eclipse.org/r/#/c/26419/ is done).

The rebuilt launchers are committed now (except for Solaris/x86 platform for which the build machine is still down).

https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=06b72165232d4264949e6543f43377fec7b35c11

https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=63fff9c96390bb150872e2efde19fb53c4420355
Comment 6 Arun Thondapu CLA 2014-05-23 09:55:15 EDT
Verified in I20140522-1330.
Comment 7 Dani Megert CLA 2014-06-04 07:01:21 EDT
Filed bug 436558 for the missing documentation.
Comment 8 Markus Persson CLA 2014-09-16 07:55:27 EDT
The patch in eclipse.c is broken for Win32, since there is no setenv() function. Please exclude the added lines for Win32, at least.
Comment 9 Dani Megert CLA 2014-09-30 03:02:35 EDT
(In reply to Markus Persson from comment #8)
> The patch in eclipse.c is broken for Win32, since there is no setenv()
> function. Please exclude the added lines for Win32, at least.

Markus, please open a separate bug report. Thanks.