This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 434574 - [JFace] Deprecation of CellEditor
Summary: [JFace] Deprecation of CellEditor
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All Windows NT
: P3 normal (vote)
Target Milestone: 4.4 RC1   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-10 09:38 EDT by Jeanderson Candido CLA
Modified: 2014-05-10 13:50 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeanderson Candido CLA 2014-05-10 09:38:35 EDT 
Hello everyone,

While browsing some JFace snippets, I found in Snippet034CellEditorPerRow.java a suggestion to use EditingSupport instead of CellEditor.

If EditingSupport is newer and should be used instead of CellEditor (for 3.3 and above), would be the case to deprecate CellEditor?

Regards.
Comment 1 Thomas Schindl CLA 2014-05-10 09:59:35 EDT 
CellEditors are not deprecated Viewer#setCellEditors() is!
Comment 2 Jeanderson Candido CLA 2014-05-10 10:21:39 EDT 
(In reply to Thomas Schindl from comment #1)
> CellEditors are not deprecated Viewer#setCellEditors() is!

In this case, I think the Snippet is suggesting to use EditingSupport for a specific purpose instead of using it as a replacement for CellEditor, right?
Comment 3 Lars Vogel CLA 2014-05-10 12:17:06 EDT 
(In reply to Jeanderson Candido from comment #2)
> (In reply to Thomas Schindl from comment #1)
> > CellEditors are not deprecated Viewer#setCellEditors() is!
> 
> In this case, I think the Snippet is suggesting to use EditingSupport for a
> specific purpose instead of using it as a replacement for CellEditor, right?

We should fix the snippet description and remove the usage of Viewer#setCellEditors() in the snippets. I mark this one as WONTFIX, as we are not deprecating CellEditor.
Comment 4 Thomas Schindl CLA 2014-05-10 12:28:01 EDT 
You are mixing things - there are 2 APIs to add inline editing:
Viewer#setCellEditors and the new extremly flexible EditingSupport API!
Comment 5 Jeanderson Candido CLA 2014-05-10 13:50:24 EDT 
Thank you Thomas and Lars for the clarification.