Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 434198 - Use "Restore Hidden Toolbar Entries" as label for the context menu of toolbar entries
Summary: Use "Restore Hidden Toolbar Entries" as label for the context menu of toolbar...
Status: CLOSED DUPLICATE of bug 433979
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tony McCrary CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-06 07:32 EDT by Lars Vogel CLA
Modified: 2014-05-12 15:11 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-05-06 07:32:35 EDT 

    


    

    


      



        
          Comment 2
        

        
          Lars Vogel CLA

        

        
        

        
          2014-05-06 07:33:18 EDT
        

      






Sopot can you take this one?

    


    


      



        
          Comment 3
        

        
          Lars Vogel CLA

        

        
        

        
          2014-05-06 14:47:38 EDT
        

      






Sopot told me he is currently too busy.

    


    


      



        
          Comment 4
        

        
          Tony McCrary CLA

        

        
        

        
          2014-05-07 18:31:07 EDT
        

      






(In reply to Lars Vogel from comment #3)
> Sopot told me he is currently too busy.

I've updated the applicable properties file:
https://git.eclipse.org/r/#/c/26192/

    


    


      



        
          Comment 5
        

        
          Lars Vogel CLA

        

        
        

        
          2014-05-08 02:45:28 EDT
        

      






(In reply to Tony McCrary from comment #4)
> (In reply to Lars Vogel from comment #3)
> > Sopot told me he is currently too busy.
> 
> I've updated the applicable properties file:
> https://git.eclipse.org/r/#/c/26192/

As stated in https://bugs.eclipse.org/bugs/show_bug.cgi?id=433979#c12 I think "Restore Hidden Toolbar Entries" is the correct term. Please update the Gerrit review, also ensure that the commit message header is: "

    


    


      



        
          Comment 6
        

        
          Lars Vogel CLA

        

        
        

        
          2014-05-08 02:46:28 EDT
        

      






The commit header should be the same as the bug title "Bug 434198 - Use "Restore Hidden Toolbar Entries" as label for the context menu of toolbar entries"

Sorry for the confusion with the title and the comment, thanks for your help. Would be great if you can update the Gerrit review.

    


    


      



        
          Comment 7
        

        
          Lars Vogel CLA

        

        
        

        
          2014-05-08 15:03:02 EDT
        

      






(In reply to Tony McCrary from comment #4)

Thanks. I updated the Gerrit review, there is no need for you to update it anymore. Sorry for the confusion.

    


    


      



        
          Comment 8
        

        
          Lars Vogel CLA

        

        
        

        
          2014-05-08 15:04:01 EDT
        

      






Please review https://git.eclipse.org/r/#/c/26192/

    


    


      



        
          Comment 9
        

        
          Markus Keller CLA

        

        
        

        
          2014-05-08 15:08:19 EDT
        

      






This separate change is not necessary, since bug 433979 will have to remove the feature anyway.

    


    


      



        
          Comment 10
        

        
          Lars Vogel CLA

        

        
        

        
          2014-05-08 15:10:31 EDT
        

      






(In reply to Markus Keller from comment #9)
> This separate change is not necessary, since bug 433979 will have to remove
> the feature anyway.

I'm about to fix Bug 433979.

    


    


      



        
          Comment 11
        

        
          Lars Vogel CLA

        

        
        

        
          2014-05-09 15:11:51 EDT
        

      






(In reply to Lars Vogel from comment #10)
> (In reply to Markus Keller from comment #9)
> > This separate change is not necessary, since bug 433979 will have to remove
> > the feature anyway.
> 
> I'm about to fix Bug 433979.

Markus, is the new text still OK with the decision from https://bugs.eclipse.org/bugs/show_bug.cgi?id=433979#c27

    


    


      



        
          Comment 12
        

        
          Markus Keller CLA

        

        
        

        
          2014-05-12 15:06:13 EDT
        

      






The Gerrit review still has a non-matching bug title in the commit message. And I really don't know why I should spend time reviewing this separately, give that bug 433979 will change the functionality anyway. Just include the fix in bug 433979.

"Restore Hidden Toolbar Entries" would be OK as menu text if that's what the menu will do.

The CPD talks about toolbar items and command groups. If the "Hide" menu will hide "Items" or "Groups" then the "Restore" menu should use the same terminology. If it's about a third kind, then "Entries" is probably fine.

*** This bug has been marked as a duplicate of bug 433979 ***