Community
Participate
Working Groups
Follow-up to bug 433830. (In reply to Andrea Guarinoni from bug 433830 comment #17) > Created attachment 242609 [details] > I20140501-0200_themes_screenshots The background color of the active Package Explorer view's toolbar on the 2nd line also looks bad on the Mac theme (like Dark, Windows 7, and Windows XP Blue in the screenshots). Andrea suggested to leave the toolbars unstyled, and I guess that's the best solution for the E4 themes for now.
(In reply to Markus Keller from comment #0) > Andrea suggested to leave the toolbars unstyled, and I guess that's the best > solution for the E4 themes for now. All E4 related themes share the same CTabFolder renderer that contains changes from the Bug 430872. However the main issue here is connected to the workarounds that we have to use in order to bypass the Bug 433276 (additional SWT event listeners as well as the hacks in the CSS files). I will try to prepare the reasonable fix for that keeping in mind the API freeze. BTW. There is another issue reported by Paul that we can attach to the list - Bug 433902 Daniel
I agree, this is a must fix for Luna.
*** Bug 433902 has been marked as a duplicate of this bug. ***
I've pushed to Gerrit the first version of the patch - https://git.eclipse.org/r/#/c/26449/ There is one refreshing issue in the Dark theme during resizing the MPart (I'm working on it). The rest seems to work fine. We definitely need the patch for the Bug 433276 in order to fix it in the proper manner Daniel
Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4f3bc6e3c42b37e197035c9b372c1907e2f3f917 PW
Verified in I20140513-2000.
Note though, that you now again use ACTIVE_TAB_BG_END to set the whole background of the part and not just the 2nd line of the toolbar, i.e. bug 430872 is back.
(In reply to Dani Megert from comment #6) > Verified in I20140513-2000. As soon as one puts parts side by side (vertically or horizontally), the bug is back. Not sure how this can happen?
Created attachment 243128 [details] Picture of the bug
(In reply to Dani Megert from comment #9) > Created attachment 243128 [details] > Picture of the bug It looks like another refreshing issue, I will take a look at it, Daniel
I've reverted all changes related to the Bug 430872 - https://git.eclipse.org/r/#/c/26684/ After applying the patch we will have working M6 version of the CTabRendering renderer Daniel
(In reply to Daniel Rolka from comment #11) > I've reverted all changes related to the Bug 430872 - > https://git.eclipse.org/r/#/c/26684/ > > After applying the patch we will have working M6 version of the > CTabRendering renderer > > Daniel This fix brings back bug 433858 (cheese)!
(In reply to Dani Megert from comment #9) > Created attachment 243128 [details] > Picture of the bug Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d09eb7036e58a3e889764dad669cbf2af5ebde8c Fixes the case where one view is on top of the other. PW
(In reply to Dani Megert from comment #12) > > This fix brings back bug 433858 (cheese)! Obviously we submitted a revised patch that fixed this problem :-) PW
Verified in I20140522-1330.
