This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 433758 - [CSS] Performance issue with build I20140428-2000
Summary: [CSS] Performance issue with build I20140428-2000
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: Macintosh Mac OS X
: P3 critical (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Daniel Rolka CLA
QA Contact: Daniel Rolka CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-29 08:44 EDT by Jerome Cambon CLA
Modified: 2014-05-05 13:43 EDT (History)
10 users (show)

See Also:


Attachments
Thread Dump 1 (21.19 KB, text/plain)
2014-04-29 08:44 EDT, Jerome Cambon CLA
no flags Details
Thread Dump 2 (22.36 KB, text/plain)
2014-04-29 08:45 EDT, Jerome Cambon CLA
no flags Details
Thread Dump 3 (21.48 KB, text/plain)
2014-04-29 08:45 EDT, Jerome Cambon CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Cambon CLA 2014-04-29 08:44:07 EDT
After updated Eclipse to build I20140428-2000,
I am getting performance issue editing a java file, I get more than 100% CPU usage. One of my colleague get the same issue.
Performance was fine with I20140427-2030 and earlier I-Builds.
See attached Thread Dumps.
Comment 1 Jerome Cambon CLA 2014-04-29 08:44:40 EDT
Created attachment 242473 [details]
Thread Dump 1
Comment 2 Jerome Cambon CLA 2014-04-29 08:45:02 EDT
Created attachment 242474 [details]
Thread Dump 2
Comment 3 Jerome Cambon CLA 2014-04-29 08:45:27 EDT
Created attachment 242475 [details]
Thread Dump 3
Comment 4 Jerome Cambon CLA 2014-04-29 09:37:19 EDT
seems to be a Mac specific issue (I'm running Mac OS 10.9.2)
Comment 5 Dani Megert CLA 2014-04-29 10:04:34 EDT
I'm not sure the dump is accurate since there's not indication of typing in any of the traces.

Another team member did not notice big performance impacts on his Mac.
Comment 6 Dani Megert CLA 2014-04-29 10:05:17 EDT
Is it only in Java files or also when editing a simple text file?
Comment 7 Jerome Cambon CLA 2014-04-29 10:17:47 EDT
(In reply to Dani Megert from comment #5)
> I'm not sure the dump is accurate since there's not indication of typing in
> any of the traces.
> 
> Another team member did not notice big performance impacts on his Mac.

I got the thread dump while the CPU with around 100% of CPU

On our side, we noticed the issue on both Mac OS 10.8 and 10.9.
Comment 8 Dani Megert CLA 2014-04-29 10:19:41 EDT
(In reply to Jerome Cambon from comment #7)
> (In reply to Dani Megert from comment #5)
> > I'm not sure the dump is accurate since there's not indication of typing in
> > any of the traces.
> > 
> > Another team member did not notice big performance impacts on his Mac.
> 
> I got the thread dump while the CPU with around 100% of CPU
> 
> On our side, we noticed the issue on both Mac OS 10.8 and 10.9.

Maybe you have some different setup? Do you also see it with a new workspace? And when editing a text file?
Comment 9 Jerome Cambon CLA 2014-04-29 10:28:10 EDT
(In reply to Dani Megert from comment #8)
> (In reply to Jerome Cambon from comment #7)
> > (In reply to Dani Megert from comment #5)
> > > I'm not sure the dump is accurate since there's not indication of typing in
> > > any of the traces.
> > > 
> > > Another team member did not notice big performance impacts on his Mac.
> > 
> > I got the thread dump while the CPU with around 100% of CPU
> > 
> > On our side, we noticed the issue on both Mac OS 10.8 and 10.9.
> 
> Maybe you have some different setup? Do you also see it with a new
> workspace? And when editing a text file?

Yes, I can see this with a new Workspace, with default setting. As soon as I create a Java project I get more than 100% CPU usage.

So this is a general perf issue: I also get the issue while playing with Package Explorer, editing txt files, debugging, etc...
Comment 10 Markus Keller CLA 2014-04-29 10:38:03 EDT
This is an issue with E4 themes. I work in the Classic theme, where performance is still OK for me in I20140428-2000.

As soon as I switch to the Mac theme, I also get high CPU usage, and jstack traces show constant CSS and part content rendering triggered by the CSSSWTApplyStylesListener$1 or PartRenderingEngine. This seems to go on forever when the "General > Show heap status" preference is enabled. When I disable that and let Eclipse rest for about 20 seconds, then CPU load temporarily goes down.
Comment 11 Jerome Cambon CLA 2014-04-29 11:00:38 EDT
I confirm that switching to Classic theme fix the issue :-)
Comment 12 Brian de Alwis CLA 2014-04-29 11:12:58 EDT
I see this too.  I forgot that you can also specify a special theme 'none' from the command line to disable CSS entirely (-cssTheme none).

The keyboard still feels a bit laggy when typing, but that's unchanged from I20140427.
Comment 13 Daniel Rolka CLA 2014-04-29 11:19:25 EDT
It seems to be connected to the changes introduced with the bug 430872 (changes in the CTabRendering.redrawChildren method).

It affects the 'e4 default' as well as the 'Dark' theme - both use the custom e4 CTabFolder renderer that is corrupted.

You can use the 'classic' theme that uses the default renderer, as another workaround for the issue

I will investigate it,
Daniel
Comment 15 Igor Fedorenko CLA 2014-05-02 14:34:04 EDT
Can you confirm this is fixed in M7 available from download.eclipse.org? I just tried and "mac" theme is horribly slow on OSX 10.9.2.
Comment 16 Markus Keller CLA 2014-05-05 13:43:29 EDT
The severe performance issues I saw with the Mac theme in I20140428-2000 are fixed in Luna M7 (Mac 10.9.2, JDK 8).

Igor, please open a new bug with thread dumps if you still see problems.