This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 433494 - [Trim] Toolbar handlers look bad when Eclipse started with a fresh workspace
Summary: [Trim] Toolbar handlers look bad when Eclipse started with a fresh workspace
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Daniel Rolka CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-25 05:12 EDT by Wojciech Sudol CLA
Modified: 2014-04-28 11:38 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot of the toolbars. (48.21 KB, image/png)
2014-04-25 05:12 EDT, Wojciech Sudol CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wojciech Sudol CLA 2014-04-25 05:12:25 EDT 
Created attachment 242316 [details]
Screenshot of the toolbars.

Scenario:
1. Run Eclipse N20140424-2000 with a fresh workspace
2. Close Welcome page

Problem:
Toolbar handlers are wide and looks bad - see screenshot.
No errors in the log file.

Workaround:
Restart Eclipse.

Environment:
OS: Windows 7 x64
Eclipse theme: "Windows 7"
Comment 2 Markus Keller CLA 2014-04-25 07:39:00 EDT 
The dispose listener in ImageBasedFrame is not doing anything valuable, since the widget sets the data field to null anyway when it is disposed.
Comment 3 Daniel Rolka CLA 2014-04-28 03:07:17 EDT 
(In reply to Markus Keller from comment #2)
> The dispose listener in ImageBasedFrame is not doing anything valuable,
> since the widget sets the data field to null anyway when it is disposed.

Thanks for hint. Released as: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4ea179cbfde2e605c7ae46dbeb8012618cec7f05

Daniel
Comment 4 Dani Megert CLA 2014-04-28 03:13:00 EDT 
VERIFIED in I20140427-2030.
Comment 5 Dani Megert CLA 2014-04-28 11:38:36 EDT 
(In reply to Daniel Rolka from comment #3)
> (In reply to Markus Keller from comment #2)
> > The dispose listener in ImageBasedFrame is not doing anything valuable,
> > since the widget sets the data field to null anyway when it is disposed.
> 
> Thanks for hint. Released as:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=4ea179cbfde2e605c7ae46dbeb8012618cec7f05
> 
> Daniel

Next time, please make sure to also remove unused imports and in general, fix warnings that are in the file(s).