This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 433154 - Inconsistent handling of split stacks
Summary: Inconsistent handling of split stacks
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-21 15:33 EDT by Eric Moffatt CLA
Modified: 2014-04-30 14:46 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2014-04-21 15:33:11 EDT
We don't handle splitting stacks the same way depending on the orientation of the split.

to Repoduce:

Start with a fresh Java perspective

Drag the Problems view to split the Package Explorer side-by-side

Drag it back where it was...notice that the Package Explorer is the same size it was before the split

Now drag it to split the Outline view side-by-side and back again

Notice that the Outline does *not* go back to its original size

This is the result of an 'optimization' that tried to minimize the number of PartSashContainers we create by allowing more than two if the orientation is the same direction. but this leaves the 'weights' incorrect. It's better to remove the optimization, allowing better control over the weights. Note that this is not a performance issue since we share a single Composite.
Comment 1 Eric Moffatt CLA 2014-04-21 15:38:33 EDT
Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=724fc1ea5247f79ce7e9d01c96bafb30baca23e0

This removes the bogus optimization as well as providing a special CCE check in the 'findElementsRecursive' method which I came across while testing.
Comment 2 Eric Moffatt CLA 2014-04-30 14:46:15 EDT
Verified in 4.4.0.I20140430-0800