Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 433044 - [breakpoints] Deleting a breakpoint from the gdb console causes it to be re-installed
Summary: [breakpoints] Deleting a breakpoint from the gdb console causes it to be re-i...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.4.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.4.0   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-17 15:40 EDT by Marc Khouzam CLA
Modified: 2014-04-22 04:39 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2014-04-17 15:40:23 EDT 
With the change I made to bug 431986, I messed up the deletion of breakpoints from the gdb console.

To reproduce:
1- start a program with a bp
2- from the gdb console delete that breakpoint
=> that breakpoint will remain installed.  Looking at the gdb traces one can see it was deleted and installed again in GDB

I am investigating now.
Comment 1 Marc Khouzam CLA 2014-04-18 08:04:21 EDT 
When deleting a breakpoint from the gdb console, the corresponding platform breakpoint remains enabled, as it should.  The problem is that because the platform breakpoint is enabled, we will try to re-install it at the first opportunity.

We need a way to specify that for a particular session, the platform breakpoint should not be re-installed.  This was done before by completely filtering out (using thread filtering) the breakpoint from the processes of the debug session in MIBreakpointsManager#uninstallBreakpoint().  I mistakenly removed this in bug 431986 because I didn't consider the particular scenario of uninstalling a breakpoint while keeping the platform one enabled.

I added back this logic:
  https://git.eclipse.org/r/25266

I also enhanced the JUnit tests to verify this case.

Mikhail, can you have a look?
Comment 2 Marc Khouzam CLA 2014-04-22 04:39:00 EDT 
Committed to master.
Thanks Mikhail.