432779 – [Trim] [Themes] More wasted space above editor tabs in classic themes

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 432779 - [Trim] [Themes] More wasted space above editor tabs in classic themes

Summary: [Trim] [Themes] More wasted space above editor tabs in classic themes

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.4
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	4.4 M7
Assignee:	Eric Moffatt
QA Contact:	Eric Moffatt

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	501413
	Show dependency tree

Reported:	2014-04-15 01:21 EDT by Marc-André Laperle
Modified:	2016-09-14 06:11 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Default theme (3.84 KB, image/png) 2014-04-15 01:21 EDT, Marc-André Laperle	no flags	Details
Classic before patch (3.95 KB, image/png) 2014-04-15 01:22 EDT, Marc-André Laperle	no flags	Details
Classic after patch (3.81 KB, image/png) 2014-04-15 01:22 EDT, Marc-André Laperle	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc-André Laperle

2014-04-15 01:21:56 EDT

Created attachment 241990 [details]
Default theme

Using Eclipse 4.4-I20140408-1645

1. Switch to the Classic theme (or Windows 7 Classic). Restart.
2. Open two text files
3. Drag one of the editor tabs to split the editor area in two
4. The white space above the tabs is much bigger then the non-classic themes (seen screenshots)

Comment 1 Marc-André Laperle

2014-04-15 01:22:19 EDT

Created attachment 241991 [details]
Classic before patch

Comment 2 Marc-André Laperle

2014-04-15 01:22:43 EDT

Created attachment 241992 [details]
Classic after patch

Comment 3 Marc-André Laperle

2014-04-15 01:25:54 EDT

Patch:
https://git.eclipse.org/r/#/c/25021/

Comment 4 Paul Webster

2014-04-15 09:07:34 EDT

It's because of the affordance for the min/max buttons for the shared area.  There might already be a bug about this.

PW

Comment 5 Paul Webster

2014-04-15 09:08:28 EDT

Oh. sorry, it's about the classic theme not having the same compression as the default theme.

PW

Comment 6 Eric Moffatt

2014-04-17 13:39:03 EDT

Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b3e1e16d30312f3da046f1d1d5cea87447e6ffc7

Thanks again...

Comment 7 Eric Moffatt

2014-05-01 10:11:19 EDT

Verified in 4.4.0.I20140501-0200.