Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 432776 - move and simplify eclipse.platform.repository
Summary: move and simplify eclipse.platform.repository
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 406825
Blocks:
  Show dependency tree
 
Reported: 2014-04-14 23:17 EDT by David Williams CLA
Modified: 2014-04-17 08:52 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-04-14 23:17:49 EDT
I'm in the final stages of getting rid of the "master features" in our build (left over from driving the PDE build) ... the features being moved directly to category.xml file, instead of the category.xml file including (only) the master feature ... and, in the course of that it seems there's room for clarity and simplification ... 

1) I propose to move "eclipse.platform.repository" into the tychoeclipsebuilder project itself. Admittedly, it's "merely" for conceptual clarity, as tychoeclipsebuilder seems devoted to producing the "deliverables" in the form we want, based on the rest of the actual build. So, in that sense, conceptually fits there. 

Does anyone remember why it was "separate from" tychoeclipsebuilder to begin with? Coincidence or technically required? 

If no one knows or remember why it was not in tychoeclipsebuilder to begin with, I'm going to move it into there ... as I think makes it conceptually cleaner (And, I suspect, make future improvements conceptually easier.) 

2) In the category.xml file, what we had before seemed to spell out the master feature in great detail, such using a very specific URL such as 

    <feature
        url="../eclipse.platform.releng/features/master/master-3.4.0-SNAPSHOT.jar"
        id="master"
        version="0.0.0">
    </feature>

and I know using the PDE's "category editor" will produce slightly less so, but still complicated form, such as 

  <feature
    url="features/org.eclipse.core.runtime.feature_1.1.0.qualifier.jar"
    id="org.eclipse.core.runtime.feature"
    version="1.1.0.qualifier" />

But, it seems to me, using the text editor, that simply specifying 

  <feature
    id="org.eclipse.core.runtime.feature"
    version="0.0.0" />

suffices, and from my test builds, gives the same results. 

Does anyone know how/why it's better to specify a complicated, specific URL? 

If not, I plan to go the "text editor" route and simplify how the features are specified (plus, we have one, 'bundle', for the jdt.core batch compiler).
Comment 1 David Williams CLA 2014-04-14 23:24:30 EDT
Igor, Paul, Thanh, 

I know it was a long time since originally created, but anyone remember why the "full repository" part of the build was outside tychoeclipsebuilder? 

Anyone have any advise on why not to leave out "url" from category.xml file?
Comment 2 David Williams CLA 2014-04-17 08:25:28 EDT
This was fixed with changes made at same time, for bug 406825.
Comment 3 Paul Webster CLA 2014-04-17 08:52:38 EDT
(In reply to David Williams from comment #1)
> Igor, Paul, Thanh, 
> 
> I know it was a long time since originally created, but anyone remember why
> the "full repository" part of the build was outside tychoeclipsebuilder? 

It was created first, IIRC, and was there so we got a final aggregate p2 repo.  We created tychoeclipsebuilder to mirror the old releng.eclipsebuilder that contained product and build feature metadata, and then it grew to what it is today.

While I'm not 100% sure, the only thing that matters is that it runs last.

PW