This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 432652 - [Dialogs] Keep internal ResourceTreeAndListGroup for compatibility
Summary: [Dialogs] Keep internal ResourceTreeAndListGroup for compatibility
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Wojciech Sudol CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-11 18:25 EDT by Marc-André Laperle CLA
Modified: 2014-04-14 11:12 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2014-04-11 18:25:50 EDT 
Bug 147027 made ResourceTreeAndListGroup public but removed the internal one. It think it would be reasonably easy to keep the internal class and make it extend the public class, similarly to IElementFilter. This would make it easier for us to support both Kepler and Luna without copying a lot of code.

I will post a patch on Gerrit.
Comment 1 Marc-André Laperle CLA 2014-04-11 18:27:46 EDT 
Patch:
https://git.eclipse.org/r/24888
Comment 2 Dani Megert CLA 2014-04-14 05:38:27 EDT 
Keeping the internal class sends the wrong signal, namely that it's OK to use internal code.

If you have the requirement to support more than one Eclipse version with the same code base, then you also have to own the compatibility layer.
Comment 3 Marc-André Laperle CLA 2014-04-14 11:12:26 EDT 
Makes sense. Thank you for the explanation.