Community
Participate
Working Groups
Created attachment 241862 [details] screen shot 1
Created attachment 241863 [details] screen shot 2
Created attachment 241865 [details] New icons for checkboxes and tab label
https://git.eclipse.org/r/#/c/24824/
Created attachment 241919 [details] screenshot 3
Created attachment 241920 [details] screenshot 4
Created attachment 241939 [details] screen shot 5 ability to select bundle, package, or class when when creating bundleclass uri. The class list will only include items in the bundle/package. The find... command in the toolbar will still search all available contributions.
Created attachment 241940 [details] screenshot 6 Note that the list is filtered by bundle/package.
Created attachment 242008 [details] screenshot: empty values added to filter by attribute
Created attachment 242357 [details] screenshot: icons for toolbar and command dropdown menu
Created attachment 242358 [details] screenshot: abracadabra is now tooltip
Created attachment 242359 [details] screenshot: abracadabra is now tooltip Last screenshot was not dectected properly by bugzilla...
(In reply to Steven Spungin from comment #12) > Created attachment 242359 [details] > screenshot: abracadabra is now tooltip > > Last screenshot was not dectected properly by bugzilla... LOL
Created attachment 242644 [details] screenshot: resource reference resolution dialog >> Also the button placement is oddly centered vertically. >> (require bundle, import package, resolve later). Consider changing this. @Wim, please compare screen shot (OSX) with your version.
Created attachment 242645 [details] screenshot: resource reference resolution dialog (icon)
Created attachment 242646 [details] screenshot: resource reference resolution dialog (icon) bugzilla has a bug: disregard previous attachment
Created attachment 242666 [details] Proposed change Please consider a selection like this. The stacked buttons, centered and each of different width is visually not very appealing. This is the preferred dialog in Eclipse. Always provide OK and Cancel to back out. I see that you hide the default buttons.
Button arrangement looks good, but I would use radio buttons instead of check boxes, and keep images. Ultimately as more options are requested this will become a wizard. I will wail for further review before submitting. @Wim, Sorry about wiping out your rebase. I did not see that you cleaned up the commit message
Created attachment 242678 [details] Proposed Change 2A
Created attachment 242679 [details] Proposed Change 2B
Created attachment 242680 [details] Proposed Change 2C (class)
Looks great.
Created attachment 242687 [details] Proposed Change 2D (selected and marked)
Created attachment 242688 [details] Consolidated Progress Report This is a summary of all issues discussed on Gerrit related to this thread. It is frustrationg using Gerrit and Bugzilla's linear threads and unformatted text, so I am posting a PDF with consolidated current progress on the referenced bug. It would be nice if Gerrit allowed an editable markup text area to be shared amongst developers per patch. Am I alone in stating this workflow could use some additional enhancements?
(In reply to Steven Spungin from comment #24) > > It is frustrationg using Gerrit and Bugzilla's linear threads and > unformatted text, so I am posting a PDF with consolidated current progress > on the referenced bug. It would be nice if Gerrit allowed an editable > markup text area to be shared amongst developers per patch. Am I alone in > stating this workflow could use some additional enhancements? I agree. Additional things to straighten out are: Mixed documentation in Gerrit and in Bugzilla The number of emails Gerrit sends drives me crazy. No reference to the commit can be found in Gerrit after publishing Can you file a bug against Gerrit?
Created attachment 242708 [details] Consolidated Progress Report
(In reply to Wim Jongman from comment #25) > (In reply to Steven Spungin from comment #24) > > > > > It is frustrationg using Gerrit and Bugzilla's linear threads and > > unformatted text, so I am posting a PDF with consolidated current progress > > on the referenced bug. It would be nice if Gerrit allowed an editable > > markup text area to be shared amongst developers per patch. Am I alone in > > stating this workflow could use some additional enhancements? > > I agree. Additional things to straighten out are: > > Mixed documentation in Gerrit and in Bugzilla > The number of emails Gerrit sends drives me crazy. > No reference to the commit can be found in Gerrit after publishing > My wish list: Create a Bug at the same time I push code for review, reference the BugId in the commit message, and put a link to the patch in Bugzilla. Summary reports for comments Filter out Hudson comments > Can you file a bug against Gerrit? I think a 3rd party solution would be best, as Bugzilla and Gerrit know nothing about each other. Furthermore, both platforms are strictly against editing messages. I would propose a new project that consolidates the two, and creates an editable document to reference from the thread. It would pull and push relevant information from both. Both platforms have a REST API so it most likely would work. The integration project would only store information that did not fit on the other platforms. other research: https://bugs.freedesktop.org/show_bug.cgi?id=53092 http://code.google.com/p/gerrit/issues/detail?id=124 I don't want to get any more off topic here, so I will start a blog and send you a link.
Created attachment 242847 [details] Consolidated Progress Report
Merged: https://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?id=86219b10a48721781e74baba94e19487b01c312c
Also fixed with https://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?id=23d21424073f1c6795657c62162ed15783577fbf
Gerrit Review: https://git.eclipse.org/r/#/c/24824/ Also fixed with https://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?id=23d21424073f1c6795657c62162ed15783577fbf
