431992 – [Perspectives] Clean up CustomizePerspectiveDialog dialog

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 431992 - [Perspectives] Clean up CustomizePerspectiveDialog dialog

Summary: [Perspectives] Clean up CustomizePerspectiveDialog dialog

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.4
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.4 M7
Assignee:	Lars Vogel
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	420779
	Show dependency tree

Reported:	2014-04-04 06:14 EDT by Lars Vogel
Modified:	2014-04-22 08:56 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2014-04-04 06:14:11 EDT

We have several bug reports for CustomizePerspectiveDialog. Before looking at them I would like to cleanup the code without any function change.

Comment 1 Lars Vogel

2014-04-04 06:22:20 EDT

Runing the Source Clean-up actions https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=243ba2902f2dee286b2122240bb8b7ef8d4109e4

Comment 2 Lars Vogel

2014-04-04 06:26:54 EDT

Removed unused attribute and lots of of raw warning messages https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=321f7f69d51c768b573564d291ca2bea133c968b

Comment 3 Lars Vogel

2014-04-04 06:47:57 EDT

Sorry Gerrit issue, correct commits:

(In reply to Lars Vogel from comment #1)
> Runing the Source Clean-up actions
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f64a0cdc7e595f18dfc1b3da5e299af2dde6f8e8

Removed unused attribute and lots of of raw warning messages 

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1670a9f8b1aa478a83937ad91af9f1707723896b

Comment 4 Lars Vogel

2014-04-04 06:49:27 EDT

Deletes unnecessary Javadoc

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4cff0c3c10bfc0e3a6320e82d9a2be3636aa6dea

Comment 5 Lars Vogel

2014-04-04 06:50:20 EDT

Deletes incorrectly overridden method https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=862562a60b338a5ea1eb79ae6457de832d480932

Comment 6 Lars Vogel

2014-04-04 07:00:14 EDT

Iterator to enhanced for loop https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4f078ce64379fae39070fab2e7e3b26f70b9976e

Comment 7 Lars Vogel

2014-04-07 11:24:04 EDT

More minor cleanups

https://git.eclipse.org/r/24560
https://git.eclipse.org/r/24561
https://git.eclipse.org/r/24562

Comment 8 Lars Vogel

2014-04-07 15:47:37 EDT

(In reply to Lars Vogel from comment #7)
> More minor cleanups
> 
> https://git.eclipse.org/r/24560
> https://git.eclipse.org/r/24561
> https://git.eclipse.org/r/24562

Applied with 

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d3e936ddbc328e0327a990bd09724ff3efc6be6e

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=71c7e91dffcc64062e69e1ecc4be5fff6bcdc944

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7d1b9ac72c6afe6cf4563adbfe1452f85f2f8675

Comment 9 Lars Vogel

2014-04-09 02:55:03 EDT

I had plans to fix this dialog but it feels to me that the deep embedded assumption that ActionGroup/ Command Groups are present makes it impossible to fix it. I make my cleanup activities are fixed. I think I made a minor part of the code better readable.

Comment 10 Lars Vogel

2014-04-22 08:56:46 EDT

Trivial clean up, verified in Build id: N20140421-2000 that the existing bugs referred to by Bug 420956 are still present. :/