This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 431798 - EModelService.findElements does not find bindings and bindingtables
Summary: EModelService.findElements does not find bindings and bindingtables
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.4 RC1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 383403
Blocks:
  Show dependency tree
 
Reported: 2014-04-02 08:00 EDT by Paul Seibt CLA
Modified: 2014-05-26 14:59 EDT (History)
3 users (show)

See Also:
pwebster: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Seibt CLA 2014-04-02 08:00:32 EDT 
Please see also Bugs 431714 and 383403.
Comment 1 Lars Vogel CLA 2014-04-02 08:01:28 EDT 
Louis, can you take this one also?
Comment 2 Paul Seibt CLA 2014-04-02 08:03:21 EDT 
Bug 431714 and Bug 383403 for the links.
Comment 3 Paul Webster CLA 2014-04-04 14:40:19 EDT 
Fixed by Bug 431714

PW
Comment 4 Lars Vogel CLA 2014-04-07 06:06:52 EDT 
Louis, can you validate that this work with a recent nightly build?
Comment 5 Louis-Michel Mathurin CLA 2014-04-07 07:58:18 EDT 
Is there a special process?  I fetch changes and pull into my branch this morning and it work.
Comment 6 Lars Vogel CLA 2014-04-07 08:11:29 EDT 
(In reply to Lars Vogel from comment #4)
> Louis, can you validate that this work with a recent nightly build?

We typically download a recent build and vslidate that the change also works in the created product.
Comment 7 Louis-Michel Mathurin CLA 2014-04-07 08:19:43 EDT 
Here is my understanding of the step.
1) Download a nightly build
2) Create an RCP app 
(since this was not possible to find bindings before with the method, there is little chance that the IDE already use the new method to find bindings !)
3) Try to find bindings/bindingtables via the API

IF everything work, what is the next step? write another comment?
Comment 8 Lars Vogel CLA 2014-04-07 08:41:06 EDT 
Yes, please  write another comment, or change this bug status to verified. Not sure if only committers can do that.
Comment 9 Paul Webster CLA 2014-05-01 10:10:29 EDT 
We find MBindingTables, but not MKeyBinding.

If looking for MKeyBindings, we need to include MBindingTables to search, and if the root is an MBindingTable we need to look through the MKeyBindings.

PW
Comment 10 Louis-Michel Mathurin CLA 2014-05-01 14:17:14 EDT 
See Gerrit:
https://git.eclipse.org/r/#/c/25844/

Note:  Will only work with the flag ANYWHERE.
Comment 11 Lars Vogel CLA 2014-05-07 07:46:22 EDT 
Paul is that something you would consider for RC1?
Comment 13 Paul Webster CLA 2014-05-26 14:59:40 EDT 
In 4.4.0.I20140522-1330

PW