This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 431707 - [QuickAccess] Quick Access should open a dialog if hidden
Summary: [QuickAccess] Quick Access should open a dialog if hidden
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Missing name Mising name CLA
QA Contact: Daniel Rolka CLA
URL:
Whiteboard:
Keywords: noteworthy
: 529286 (view as bug list)
Depends on:
Blocks: 362420 427999 433778 481031
  Show dependency tree
 
Reported: 2014-04-01 09:20 EDT by Lars Vogel CLA
Modified: 2019-09-02 05:27 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-04-01 09:20:45 EDT 
If the user hides the the toolbar via Window -> Hide Toolbar the Ctrl+3 shows this toolbar again. 

In case the toolbar is hidden, a dialog should be opened (as the old Quick Access) and the toolbar should stay hidden.

Relevant class: org.eclipse.ui.internal.quickaccess.SearchField
Comment 1 Paul Webster CLA 2014-04-01 09:31:56 EDT 
This was one of the possible solutions in the search field bug 362420

Please make that one depend on this one then.

PW
Comment 2 Missing name Mising name CLA 2014-04-01 12:46:39 EDT 
I provided a fix which shows the QuickAccess-Dialog if either the toolbars are hidden (as described in this bug) or the SearchField doesn't exist.

Take a look at the Gerrit-Commit https://git.eclipse.org/r/24272 for more details.

I'm not sure if I get an OK from Hudson, because a previous fix concerning CSS styling causes an error at the moment (https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1660/).
Comment 3 Lars Vogel CLA 2014-04-02 12:53:37 EDT 
Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=557835799a4f2038a9a5a91d8cde7822384842ea

Thanks Rene for fixing that one, this used to be a major usability issue in Eclipse 4.x.
Comment 4 Paul Webster CLA 2014-04-29 11:29:08 EDT 
verified in 4.4.0.I20140428-2000 but see bug 433778
Comment 5 Mickael Istria CLA 2019-08-22 17:04:18 EDT 
*** Bug 529286 has been marked as a duplicate of this bug. ***