This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 431337 - Remove the LegacyIDE.e4xmi file from org.eclipse.ui.workbench
Summary: Remove the LegacyIDE.e4xmi file from org.eclipse.ui.workbench
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-27 06:50 EDT by Lars Vogel CLA
Modified: 2014-03-27 12:00 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-03-27 06:50:09 EDT 
Currently we have two versions of LegacyIDE.e4xmi one in org.eclipse.platform which seems to be used and one in org.eclipse.ui.workbench which seems not to be used.

I used file search. 

I suggest to remove the one in org.eclipse.ui.workbench to avoid confusion.
Comment 1 Lars Vogel CLA 2014-03-27 06:53:48 EDT 
https://git.eclipse.org/r/23981
Comment 2 Paul Webster CLA 2014-03-27 09:04:29 EDT 
The one in org.eclipse.ui.workbench is used in the RCP case.  i.e. if you create the RCP Mail app, it has to use that one since it doesn't include org.eclipse.platform.

Until we can get rid of LegacyIDE completely, we need to keep both of them in sync.

PW
Comment 3 Lars Vogel CLA 2014-03-27 09:36:17 EDT 
(In reply to Paul Webster from comment #2)
> The one in org.eclipse.ui.workbench is used in the RCP case.  i.e. if you
> create the RCP Mail app, it has to use that one since it doesn't include
> org.eclipse.platform.
> 
> Until we can get rid of LegacyIDE completely, we need to keep both of them
> in sync.

OK I mark this bug as WONTFIX. Note that the two files are currently not in sync.
Comment 4 Brian de Alwis CLA 2014-03-27 11:29:38 EDT 
Paul, why can't the org.eclipse.platform.ide use the LegacyIDE.e4xmi from org.eclipse.ui.workbench?
Comment 5 Paul Webster CLA 2014-03-27 12:00:38 EDT 
(In reply to Brian de Alwis from comment #4)
> Paul, why can't the org.eclipse.platform.ide use the LegacyIDE.e4xmi from
> org.eclipse.ui.workbench?

I guess potentially it could, although we made it the default when moving Eclipse4 over to the workbench in 4.1 (so a number of products expect it there).  We added the one in o.e.ui.workbench later to solve the problem for RCP applications, because they couldn't use the one in o.e.platform.

PW