This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 431180 - CommandServiceAddon should not have public API
Summary: CommandServiceAddon should not have public API
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 trivial (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 20:26 EDT by Lars Vogel CLA
Modified: 2014-04-07 06:01 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-03-25 20:26:19 EDT 

    


    


      



        
          Comment 1
        

        
          Lars Vogel CLA

        

        
        

        
          2014-03-25 20:26:57 EDT
        

      






I suggest to mark the init and cleanup method as package private

    


    


      



        
          Comment 2
        

        
          Lars Vogel CLA

        

        
        

        
          2014-03-25 20:27:38 EDT
        

      






https://git.eclipse.org/r/23902

    


    


      



        
          Comment 3
        

        
          Brian de Alwis CLA

        

        
        

        
          2014-03-26 15:31:57 EDT
        

      






Fixed by Lars

    


    


      



        
          Comment 4
        

        
          Lars Vogel CLA

        

        
        

        
          2014-04-07 06:01:30 EDT
        

      






Verified in Git