This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 431179 - Add missing @Override and @Deprecate annotations to org.eclipse.ui.workbench
Summary: Add missing @Override and @Deprecate annotations to org.eclipse.ui.workbench
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 20:09 EDT by Lars Vogel CLA
Modified: 2014-04-18 05:25 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-03-25 20:09:58 EDT 

    


    


      



        
          Comment 1
        

        
          Lars Vogel CLA

        

        
        

        
          2014-03-25 20:10:45 EDT
        

      






https://git.eclipse.org/r/23900

    


    


      



        
          Comment 2
        

        
          Paul Webster CLA

        

        
        

        
          2014-03-26 13:43:21 EDT
        

      






Does this remove a bunch of warnings?

PW

    


    


      



        
          Comment 3
        

        
          Lars Vogel CLA

        

        
        

        
          2014-03-27 03:47:16 EDT
        

      






(In reply to Paul Webster from comment #2)
> Does this remove a bunch of warnings?
> 
> PW

Depends on your JDT settings, a missing annotation can be set to warning or error.

    


    

    


      



        
          Comment 5
        

        
          Lars Vogel CLA

        

        
        

        
          2014-03-27 08:01:08 EDT
        

      






Looks like some @Override annotations are still missing.

    


    


      



        
          Comment 6
        

        
          Lars Vogel CLA

        

        
        

        
          2014-03-27 08:06:09 EDT
        

      






Ah sorry, I was looking at org.eclipse.e4.ui.workbench. For org.eclipse.ui.workbench I changed the project setting to issue an error if an @Override or @Deprecated annotation is missing with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2464be8ef713df24388917c3c55faf939b2c2412

    


    


      



        
          Comment 7
        

        
          Lars Vogel CLA

        

        
        

        
          2014-03-27 08:06:38 EDT
        

      






Project setting enabled -> No way this can happen again

    


    


      



        
          Comment 8
        

        
          Paul Benedict CLA

        

        
        

        
          2014-03-28 17:43:38 EDT
        

      






I was looking at the commit in comment #4 and several method declarations have gotten an unexpected tab character. I am pretty sure the misalignment wasn't intended.

    


    


      



        
          Comment 9
        

        
          Paul Benedict CLA

        

        
        

        
          2014-04-16 11:17:16 EDT
        

      






Just following up about the incorrect indentations this patch applied. Should it be fixed?

    


    


      



        
          Comment 10
        

        
          Dani Megert CLA

        

        
        

        
          2014-04-18 05:25:40 EDT
        

      






(In reply to Paul Benedict from comment #9)
> Just following up about the incorrect indentations this patch applied.
> Should it be fixed?

4 spaces got replaced by a tab and hence the alignment still looks OK if a monospace font is used.

There are two reasons for this issues:
1. Many files in Platform UI used spaces to indent, but the project specific
   formatter settings now want tabs.
2. Bug 433067.

I would not bother for now.