This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 430593 - [Contributions] Regression: Workbench window toolbar renders too many separators
Summary: [Contributions] Regression: Workbench window toolbar renders too many separators
Status: CLOSED DUPLICATE of bug 430116
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Daniel Rolka CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 06:33 EDT by Markus Keller CLA
Modified: 2014-04-01 04:22 EDT (History)
4 users (show)

See Also:

Attachments
Screenshot (40.05 KB, image/png)
2014-03-18 06:33 EDT, Markus Keller CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2014-03-18 06:33:24 EDT 
Created attachment 240976 [details]
Screenshot

Version: Luna (4.4)
Build id: N20140317-2000

The workbench window toolbar renders too many separators.
Comment 1 Timo Kinnunen CLA 2014-03-28 06:29:03 EDT 
These separators can be found with a CSS selector like ToolBar > ToolItem[style~='SWT.SEPARATOR'] but they don't respond to any CSS styling, especially to:

ToolBar > ToolItem[style~='SWT.SEPARATOR'] {
    visibility: hidden;  
}
Comment 2 Daniel Rolka CLA 2014-03-28 06:41:42 EDT 
(In reply to Timo Kinnunen from comment #1)
> These separators can be found with a CSS selector like ToolBar >
> ToolItem[style~='SWT.SEPARATOR'] but they don't respond to any CSS styling,
> especially to:
> 
> ToolBar > ToolItem[style~='SWT.SEPARATOR'] {
>     visibility: hidden;  
> }

Currently we don't support styling of the ToolItems with the CSS. We have partial implementation for it, but it is not finished

Daniel
Comment 3 Dani Megert CLA 2014-03-28 08:26:46 EDT 
This got broken during M6.
Comment 4 Paul Webster CLA 2014-03-28 11:18:08 EDT 
This is fallout from bug 402764

org.eclipse.ui.internal.CoolBarToTrimManager and ToolBarManagerRenderer should be examined to understand the difference between how we're treating separators now vs MOpaqueSeparators before (maybe we're missing a check for the opaque tag somewhere)?

PW
Comment 5 Lars Vogel CLA 2014-03-31 13:59:50 EDT 

*** This bug has been marked as a duplicate of bug 429900 ***
Comment 6 Dani Megert CLA 2014-04-01 04:22:46 EDT 

*** This bug has been marked as a duplicate of bug 430116 ***