This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 430165 - [CSS] Git Staging view looks ugly with dark theme
Summary: [CSS] Git Staging view looks ugly with dark theme
Status: CLOSED DUPLICATE of bug 430199
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-12 06:38 EDT by Lars Vogel CLA
Modified: 2014-03-14 05:53 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot (117.98 KB, image/png)
2014-03-12 06:38 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-03-12 06:38:31 EDT 
Created attachment 240799 [details]
Screenshot

See screenshot.
Comment 1 Lars Vogel CLA 2014-03-12 06:38:54 EDT 
Andrea, can you look at that?
Comment 2 Andrea Guarinoni CLA 2014-03-12 08:49:43 EDT 
This should not happen with the workaround provided in my last commits, can you try with it?
I see that you've taken the screenshot on ubuntu/linux but you have the lighter gray settings for Form elements in .MPart that, as of last theme update, should be applied only on Windows (on Windows eg. checkboxes and radio labels are forced to a native black font that cannot be seen easily with darker Form background).

There is anyway a bug in the CSS engine when it paints the widgets in active/focused Form: styles are not applied/painted until the user focus or unfocus the active Part for the first time (Form background and FormHeading background/color are white as in the default theme and then become dark on the first focus/unfocus, it happens for any Form in any tab).
Comment 3 Lars Vogel CLA 2014-03-12 10:17:51 EDT 
(In reply to Andrea Guarinoni from comment #2)
> This should not happen with the workaround provided in my last commits, can
> you try with it?
> I see that you've taken the screenshot on ubuntu/linux but you have the
> lighter gray settings for Form elements in .MPart that, as of last theme
> update, should be applied only on Windows (on Windows eg. checkboxes and
> radio labels are forced to a native black font that cannot be seen easily
> with darker Form background).

I try with the new version and update the bug. Thanks
 
> There is anyway a bug in the CSS engine when it paints the widgets in
> active/focused Form: styles are not applied/painted until the user focus or
> unfocus the active Part for the first time (Form background and FormHeading
> background/color are white as in the default theme and then become dark on
> the first focus/unfocus, it happens for any Form in any tab).

Do we have a bug for this already?
Comment 4 Andrea Guarinoni CLA 2014-03-12 11:14:24 EDT 
(In reply to Lars Vogel from comment #3)
> 
> Do we have a bug for this already?

I've just opened it: https://bugs.eclipse.org/bugs/show_bug.cgi?id=430199
Comment 5 Lars Vogel CLA 2014-03-14 05:53:53 EDT 
Thanks Andrea, the missing styling is indeed based on Bug 430199. Marking as duplicate.

*** This bug has been marked as a duplicate of bug 430199 ***