Community
Participate
Working Groups
The new about icon should be a png to look fine on a dark theme. I add David to the bug, as I think he handles the image transition.
Created attachment 240772 [details] Screenshot
Actually the menu is not dark, still the selection looks bad, see screenshot.
I'm not sure where that menu icon comes from ... but, if I can figure that out, I agree.
(In reply to David Williams from comment #3) > I'm not sure where that menu icon comes from ... but, if I can figure that > out, I agree. Should be the about icon from the product
Created attachment 240783 [details] png vs gif I could not find anything about an "about menu icon" setting, but, for many reasons, I did a little local experiment, and built "the platform" with PNG images only for the "window images". And you can see in attached image, it is using the PNG image for the menu item (on left). The right image is similar to previous attachment, which must be using the GIF image. This would seem to contradict what's said in bug 424916 ... that SWT always selects "the best image format" ... though, admitedly, for "windows images" might also be "order effects" since the "gif" images are listed first? Just seems to add to the argument to get rid of GIF images, if no reason for them. For next N-build, I'll try putting all the GIF images last in the list.
This is "experiment" to see if the "order listed" makes a difference over which is selected. Notice too I added 64x64 and 128x128 PNGs, since we had them, and I see where "product editor" allows space for them ... plus, trying to see if the results in "emblem" being displayed, on Ubuntu "scaled windows". http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=65dc2d6be9676d4c4730c2051022c7802cc3649e
Created attachment 240784 [details] no emblem in Eclipse SDK While a different topic than this bug, what I meant by "emblem" is that "Compiz" has a setting to "show emblem" when windows are "scaled" on desktop ... makes it easier to see "which is which", and, I have noticed that Eclipse SDK does not have one ... but the "Java EE Package" does. (Admittedly, the Java EE IDE I have is pretty old ... might even be Juno ... but at least Kepler). Doubt is it related to "window images" ... but ... just wanted to illustrate what I meant.
Created attachment 240785 [details] no "big emblem" either It also has a setting for "big" ... instead of "emblem". Would be cool if having "png images listed first" solved this issues (but Java EE also has some other "welcome screen" customization ... which, does not seem to be working for us? (bug 429522) ... Guess I should test a more recent version of Java EE Package ... might be gone there too?
(In reply to David Williams from comment #5) > This would seem to contradict what's said in bug 424916 ... that SWT always > selects "the best image format" ... though, admitedly, for "windows images" > might also be "order effects" since the "gif" images are listed first? > > Just seems to add to the argument to get rid of GIF images, if no reason for > them. For next N-build, I'll try putting all the GIF images last in the list. Thanks for validating the claim, I just assume that the statement was correct. I agree this is another good argument for getting rid of the icon.
(In reply to David Williams from comment #5) > Created attachment 240783 [details] > png vs gif > > I could not find anything about an "about menu icon" setting, but, for many > reasons, I did a little local experiment, and built "the platform" with PNG > images only for the "window images". The setting should be on the product or on the plugin.xml. If you enter it in the product and press "Synchronize" the product updates the extension point. I attach two screenshots which hopefully demonstrate what I mean.
Created attachment 240789 [details] Product setting for about icon
Created attachment 240790 [details] Mapping to extension point for aboutImage
(In reply to Lars Vogel from comment #10) > (In reply to David Williams from comment #5) > > Created attachment 240783 [details] > > png vs gif > > > > I could not find anything about an "about menu icon" setting, but, for many > > reasons, I did a little local experiment, and built "the platform" with PNG > > images only for the "window images". > > The setting should be on the product or on the plugin.xml. If you enter it > in the product and press "Synchronize" the product updates the extension > point. I attach two screenshots which hopefully demonstrate what I mean. I'm 99% sure that is the image that shows up in the "about box", not the one on the menu.
(In reply to David Williams from comment #13) > I'm 99% sure that is the image that shows up in the "about box", not the one > on the menu. Now that you say it, I'm 99.9% sure that you are right. ;-) Sorry for the misleading info.
Lars, I hope you have a chance to look at build http://download.eclipse.org/eclipse/downloads/drops4/N20140312-2000/ (or later) Seems to me changing the order of the icons fixes this problem (I put all the PNG files before all the GIF files) ... just want to be sure you agree, before marking fixed. Seems this is only a factor on Linux, and, I suspect, only literally for the icon used for the "About" menu item, not other "window images", such as upper left corner. Windows about menu icon looks the same, to me (compared to M6) and suspect there the "ico" file is used. And, Mac does not have any icon next to the About menu item ... there, it seem no software does. So, I think this is a highly specialized case and glad you noticed!
(In reply to David Williams from comment #15) > Lars, I hope you have a chance to look at build > http://download.eclipse.org/eclipse/downloads/drops4/N20140312-2000/ > (or later) > > Seems to me changing the order of the icons fixes this problem (I put all > the PNG files before all the GIF files) ... just want to be sure you agree, > before marking fixed. Looks much better, thank you. Marking as fixed.
Verified in Build id: N20140312-2000
