This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 430024 - [Trim] Minimizing package explorer triggers exception in the CSS engine if the dark theme is used
Summary: [Trim] Minimizing package explorer triggers exception in the CSS engine if th...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Lars Vogel CLA
QA Contact: Lars Vogel CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-10 12:32 EDT by Gorkem Ercan CLA
Modified: 2014-03-19 17:57 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gorkem Ercan CLA 2014-03-10 12:32:58 EDT
When using the dark theme, minimizing the package explorer causes the below SWT errors. This leaves the rendering of the whole workbench unusable state. Everything seems to work fine on other themes.

java.lang.IllegalArgumentException: Argument not valid
	at org.eclipse.swt.SWT.error(SWT.java:4422)
	at org.eclipse.swt.SWT.error(SWT.java:4356)
	at org.eclipse.swt.SWT.error(SWT.java:4327)
	at org.eclipse.swt.graphics.GC.drawImage(GC.java:1128)
	at org.eclipse.swt.graphics.GC.drawImage(GC.java:1112)
	at org.eclipse.e4.ui.widgets.ImageBasedFrame.drawFrame(ImageBasedFrame.java:179)
	at org.eclipse.e4.ui.widgets.ImageBasedFrame$1.paintControl(ImageBasedFrame.java:61)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:230)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4171)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1467)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1490)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1475)
	at org.eclipse.swt.widgets.Control.drawWidget(Control.java:1244)
	at org.eclipse.swt.widgets.Canvas.drawWidget(Canvas.java:166)
	at org.eclipse.swt.widgets.Widget.drawRect(Widget.java:749)
	at org.eclipse.swt.widgets.Canvas.drawRect(Canvas.java:161)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5579)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Display.applicationNextEventMatchingMask(Display.java:4963)
	at org.eclipse.swt.widgets.Display.applicationProc(Display.java:5341)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
	at org.eclipse.swt.internal.cocoa.NSApplication.nextEventMatchingMask(NSApplication.java:94)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3647)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1122)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1006)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:147)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:630)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:574)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:125)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:133)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:103)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:378)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:232)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1462)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
Comment 1 Andrea Guarinoni CLA 2014-03-11 15:42:22 EDT
This was probably caused by a wrong assignment in previous e4-dark.css:

64    .MToolControl.TrimStack {		
65        frame-image:  url(./gtkHandle.png);  <---	
66	  handle-image:  url(./gtkHandle.png); 		
67	  frame-cuts: 5px 1px 5px 16px;		
68    }

It should not happen with the updates provided in https://git.eclipse.org/r/#/c/23082/
Comment 2 Lars Vogel CLA 2014-03-17 17:47:12 EDT
Thanks Gorkem, should be fixed with Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a1e01a7f4b54aab0539c1bde9029a302075349a1

Please download one of the recent builds (or wait for M7) to see if that issue still exists.
Comment 3 Lars Vogel CLA 2014-03-17 17:47:28 EDT
.
Comment 4 Gorkem Ercan CLA 2014-03-17 18:02:57 EDT
Still same result with I20140311-1200 should it be fixed in there?