This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 429932 - [QuickAccess] Quick access field is too small
Summary: [QuickAccess] Quick access field is too small
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 normal with 1 vote (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Lars Vogel CLA
QA Contact: Daniel Rolka CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-08 04:42 EST by Torkild Resheim CLA
Modified: 2016-04-11 10:07 EDT (History)
3 users (show)

See Also:


Attachments
Screenshot illustrating the issue (13.33 KB, image/png)
2014-03-08 04:42 EST, Torkild Resheim CLA
no flags Details
Screenshot from Eclipse 4.3 (8.93 KB, image/png)
2014-03-11 09:13 EDT, Torkild Resheim CLA
no flags Details
If all toolbars are moved to the right, this is the result (42.61 KB, image/png)
2014-03-11 13:54 EDT, Timo Kinnunen CLA
no flags Details
OS X with fix (8.09 KB, image/png)
2014-03-20 18:40 EDT, Brian de Alwis CLA
no flags Details
Screenshot with the fix (177.06 KB, image/bmp)
2014-03-20 18:59 EDT, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Torkild Resheim CLA 2014-03-08 04:42:28 EST
Created attachment 240679 [details]
Screenshot illustrating the issue

The quick access text entry field is too small and cuts the hint text short.
Comment 1 Paul Webster CLA 2014-03-08 06:26:34 EST
What build is this on?

PW
Comment 2 Torkild Resheim CLA 2014-03-08 07:30:55 EST
Sorry, forgot to specify that. I got:

Eclipse SDK

Version: Luna (4.4)
Build id: I20140306-1200
Comment 3 Lars Vogel CLA 2014-03-11 09:08:47 EDT
Was this working before correctly? I did remove the search icon from the box but did not change the size of the box. Can you try with a fresh workspace?
Comment 4 Torkild Resheim CLA 2014-03-11 09:13:59 EDT
Created attachment 240760 [details]
Screenshot from Eclipse 4.3

Yes, it works correctly in Eclipse 4.3.
Comment 5 Torkild Resheim CLA 2014-03-11 09:16:14 EDT
Switching to a fresh workspace did not help.
Comment 6 Timo Kinnunen CLA 2014-03-11 13:54:27 EDT
Created attachment 240767 [details]
If all toolbars are moved to the right, this is the result

I, I just don't get this. At all. I wish I could brush this away as just another bug, but I've read too many Quick Access bug reports to know nothing related to Quick Access is just another normal bug. Yet I can still be surprised, it seems.

This is ridiculous. 

And I don't get how this situation can continue to be. I just don't.
Comment 7 Paul Webster CLA 2014-03-11 13:57:40 EDT
(In reply to Timo Kinnunen from comment #6)
> Created attachment 240767 [details]
> If all toolbars are moved to the right, this is the result

I don't see how that's too small.  If it's not related to that, please open a new bug.

PW
Comment 8 Timo Kinnunen CLA 2014-03-11 14:04:03 EDT
I appreciate all the work being done in this bug, I really do. Thank you for it. I hoped to show that the this bug can be fixed with plenty of room left still, not as a knock on anyone. 

I just don't get how this bug  should be a bug in the first place, that's all. See, there I go again.
Comment 9 Lars Vogel CLA 2014-03-11 14:52:52 EDT
(In reply to Timo Kinnunen from comment #8)
> I appreciate all the work being done in this bug, I really do. Thank you for
> it. I hoped to show that the this bug can be fixed with plenty of room left
> still, not as a knock on anyone. 
> 
> I just don't get how this bug  should be a bug in the first place, that's
> all. See, there I go again.

I still don't see how you comment is related to this bug. In general a bug has one purpose and your comment seems related to a different issue. As a general rule, please don't use bug reports to add unrelated information.
Comment 10 Timo Kinnunen CLA 2014-03-12 06:28:58 EDT
(In reply to comment #9)

> I still don't see how you comment is related to this bug. In general a bug has
> one purpose and your comment seems related to a different issue. As a general
> rule, please don't use bug reports to add unrelated information.

I am pointing out one location where there is a motherload of untapped screen space, just going completely unused. If some or all of that were given for Quick Access to use then Quick Access would almost never end up too small like in this bug, and in the rare case it still did this would be easy to correct by dragging some toolbars around a little. Or some people might even prefer for Quick Access to stay so small it can't even show its own hint text.

In addition, I'm pointing out that if this unused space had been given to Quick Access in the first place by making it -- rather than that #PerspectiveSpacer -- stretch to fill all remaining space then it's likely this bug would have never came to be. This is relevant towards preventing future regressions of this bug.
Comment 11 Lars Vogel CLA 2014-03-12 07:11:23 EDT
(In reply to Timo Kinnunen from comment #10)
> (In reply to comment #9)

Timo, please open a new bug, instead of posting unrelated infos to existing bug reports. This bug is about the incorrect default size of the QuickAccess box. If you post unrelated infos, we ignore them and your improvement suggestion will be lost.
Comment 12 Lars Vogel CLA 2014-03-19 12:51:48 EDT
Brian, you have a Mac, right? Could you look at that? Size on Windows and Linux is big enough.
Comment 13 Brian de Alwis CLA 2014-03-20 18:40:32 EDT
Created attachment 241077 [details]
OS X with fix

I see the issue described.  The problem is that computeSize() doesn't handle the curved appearance from the SWT.SEARCH.  Changing the code to use computeTrim() solves the issue, and we can get rid of the +15 pixel hack too (tested on Linux + OS X).

https://git.eclipse.org/r/23678

Paul: can you give this a try on Windows?
Comment 14 Lars Vogel CLA 2014-03-20 18:59:23 EDT
(In reply to Brian de Alwis from comment #13)

Thanks a lot. I can confirm looks still great on Linux.

> Paul: can you give this a try on Windows?

I think Paul is also on Linux.
Comment 15 Lars Vogel CLA 2014-03-20 18:59:45 EDT
Created attachment 241078 [details]
Screenshot with the fix
Comment 16 Brian de Alwis CLA 2014-03-21 22:14:51 EDT
Looks fine on Win7 too.  Committed as:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c6737d9fea116e259a64d24ad439a61ab2820154
Comment 17 Lars Vogel CLA 2014-04-07 05:57:21 EDT
Verfied on Linux with Build id: I20140402-0100, if it is still to small on Mac / Windows please reopen this bug
Comment 18 Raffi Khatchadourian CLA 2015-07-31 07:16:10 EDT
I am having a similar issue with Eclipse 4.5 but it seems a little different. In my main Eclipse instance, the quick access menu is too small (this is on mac, by the way). However, when I launch another instance of test the plugin I am developing, the menu size is fine. Is there some setting that I have tucked away somewhere that is causing the menu to be small?