This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 429917 - New splash screen does not look good on white background
Summary: New splash screen does not look good on white background
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 426260
  Show dependency tree
 
Reported: 2014-03-07 16:12 EST by Konstantin Komissarchik CLA
Modified: 2014-04-18 10:21 EDT (History)
3 users (show)

See Also:


Attachments
Screen Capture (173.04 KB, image/png)
2014-03-07 16:12 EST, Konstantin Komissarchik CLA
no flags Details
very rough prototype of possible solution (533.27 KB, image/bmp)
2014-03-12 12:21 EDT, David Williams CLA
no flags Details
coincidental shadow which could be "built in" to image? (156.19 KB, image/png)
2014-03-12 12:25 EDT, David Williams CLA
no flags Details
splash screen in action (127.39 KB, image/png)
2014-03-13 11:22 EDT, David Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2014-03-07 16:12:47 EST
Created attachment 240676 [details]
Screen Capture

When Eclipse is launched on a white background would commonly happen in a Windows file explorer, the fade to white in the new splash screen causes the splash to get lost in the background and loose definition.
Comment 1 David Williams CLA 2014-03-12 12:21:00 EDT
Created attachment 240819 [details]
very rough prototype of possible solution

The idea I'm trying to convey it that I think we just need some more color (or grey) tapered in the lower right corner, and then the "illusion" of a square box will be maintained (that is, we do not literally need a border everywhere). 

A designer will naturally have to create a "nice looking" one ... with the right corner the proper shade and with the proper "tapering" so as to look balanced (and not be in the way of the logo, or the "build id" which is sometimes displayed slightly under the "Luna" name. 


But, alternatively, looking at this prototype with "explorer", on windows, it does put a then "shadow" on the right-hand and bottom edges ... I guess that'd be another solution, but to "build in" the shadow, since there is no shadow displayed, when in actual use as a splash screen.
Comment 2 David Williams CLA 2014-03-12 12:25:22 EDT
Created attachment 240821 [details]
coincidental shadow which could be "built in" to image?
Comment 3 Timo Kinnunen CLA 2014-03-13 10:25:44 EDT
To look good a shadow would need per-pixel transparency, which I don't think is possible with SWT. No idea what the native launcher which creates that window can or can't do, though.
Comment 4 David Williams CLA 2014-03-13 10:47:18 EDT
(In reply to Timo Kinnunen from comment #3)
> To look good a shadow would need per-pixel transparency, which I don't think
> is possible with SWT. No idea what the native launcher which creates that
> window can or can't do, though.

Thanks Timo. I have heard it does _have_ to be a bitmap (BMP) file ... so, (as little as I understand these things) that wold not be possible. In which case, a "filled in" corner would be best approach.
Comment 5 David Williams CLA 2014-03-13 11:22:17 EDT
Created attachment 240867 [details]
splash screen in action

As a reminder, I thought it might help Ian and designer to see the splash screen "in action" ... showing the "buildId" (under "Luna") and the progress bar. 

Not everyone will see those, under all conditions or "products", but thought by attaching them there would be a better idea of "areas to avoid" -- avoid adding color in the corder, that is. 

Not sure about the progress bar. It does help "define" the square, but the point of showing it is not to count on that (since is not always present). It is to admit I'm not sure of "how to handle" that. My intuition is the progress bar will "overlay" any image that is there ... but, not sure.
Comment 6 David Williams CLA 2014-03-23 23:11:51 EDT
I've added the new splash provided in bug 426260 comment 97, and will optimistically assume it fixes this issue. 

Should be in Monday's Nightly build ... and Tuesday's I-build, if you (anyone) would care to confirm. 

http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=92a8888620fb35f02cc9e605a51c98986ed0a1b9
Comment 7 Markus Keller CLA 2014-03-24 11:14:27 EDT
(In reply to David Williams from comment #6)
> I've added the new splash provided in bug 426260 comment 97

The new splash screen is too tall (a rectangle that is too close to a square doesn't look good). The logo is not vertically centered any more, and the progress bar and text have lost their bottom alignment.
Comment 8 David Williams CLA 2014-03-24 14:50:56 EDT
Thanks Markus ... it never dawned on me they'd change its size. I'll comment in "home bug", if no one has yet.
Comment 9 David Williams CLA 2014-03-24 15:06:03 EDT
(In reply to David Williams from comment #8)
> Thanks Markus ... it never dawned on me they'd change its size. I'll comment
> in "home bug", if no one has yet.

I've reverted to the previous version. 

http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=20e4b2be9a7152c85dd4e96c474324f0c1b05f41
Comment 10 David Williams CLA 2014-03-27 11:35:45 EDT
I've committed a the newest splash screen from bug 426260 comment 102. (still the 5.0) theme. It is same size as previous (current) one ... slight coloring in lower right corner. 

http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=095e23ec82cab77bb2771714832b76fabdfc75ba
Comment 11 David Williams CLA 2014-04-18 10:21:35 EDT
While I didn't open the bug, I'll verify that new splash screen solves original problem and I think looks very nice. 

Besides the slight "grey splotch" in lower right corner on my display there also appears a thin (1 pixel?) black line all around the whole image ... which, (oddly?), I only see on Windows?